Skip to content

fix: ensure proper length calculation and fix typos #16171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
Oct 15, 2026
Merged

fix: ensure proper length calculation and fix typos #16171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64c34cc
docs: fix typo in `blas/ext/base/ndarray/dediff`
claude Oct 15, 2026
4c7bc93
docs: fix typo in `blas/ext/base/ndarray/sediff`
claude Oct 15, 2026
701ff56
fix: validate output array length for negative `k` in `blas/ext/base/…
claude Oct 15, 2026
1e1c0f2
fix: validate output array length for negative `k` in `blas/ext/base/…
claude Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/dleft-pad-circular/src/addon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 );
STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+k, strideY, argv, 4 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+((k>0)?k:0), strideY, argv, 4 );

@kgryte kgryte Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @headlessNode This likely applies to edge padding, as well, and any other strided pad API.

@kgryte kgryte Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode If you can fix your other open PRs, that would be great. Cheers!

API_SUFFIX(stdlib_strided_dleft_pad_circular)( N, k, X, strideX, Y, strideY );
return NULL;
}
Expand All @@ -59,7 +59,7 @@ static napi_value addon_method( napi_env env, napi_callback_info info ) {
STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 6 );
STDLIB_NAPI_ARGV_INT64( env, offsetY, argv, 7 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+k, strideY, argv, 5 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+((k>0)?k:0), strideY, argv, 5 );
API_SUFFIX(stdlib_strided_dleft_pad_circular_ndarray)( N, k, X, strideX, offsetX, Y, strideY, offsetY );
return NULL;
}
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/ndarray/dediff/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ The function has the following parameters:
- **arrays**: array-like object containing the following ndarrays:

- a one-dimensional input ndarray.
- a one-dimensional ndarray containing values to prepend after to computing differences.
- a one-dimensional ndarray containing values to append after to computing differences.
- a one-dimensional ndarray containing values to prepend after computing differences.
- a one-dimensional ndarray containing values to append after computing differences.
- a one-dimensional output ndarray. Must have `N + N1 + N2 - 1` elements, where `N` is the number of elements in the input ndarray, `N1` is the number of elements to prepend, and `N2` is the number of elements to append.

</section>
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/ndarray/sediff/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ The function has the following parameters:
- **arrays**: array-like object containing the following ndarrays:

- a one-dimensional input ndarray.
- a one-dimensional ndarray containing values to prepend after to computing differences.
- a one-dimensional ndarray containing values to append after to computing differences.
- a one-dimensional ndarray containing values to prepend after computing differences.
- a one-dimensional ndarray containing values to append after computing differences.
- a one-dimensional output ndarray. Must have `N + N1 + N2 - 1` elements, where `N` is the number of elements in the input ndarray, `N1` is the number of elements to prepend, and `N2` is the number of elements to append.

</section>
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/sright-pad-circular/src/addon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 3 );
STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N+k, strideY, argv, 4 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N+((k>0)?k:0), strideY, argv, 4 );
API_SUFFIX(stdlib_strided_sright_pad_circular)( N, k, X, strideX, Y, strideY );
return NULL;
}
Expand All @@ -59,7 +59,7 @@ static napi_value addon_method( napi_env env, napi_callback_info info ) {
STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 6 );
STDLIB_NAPI_ARGV_INT64( env, offsetY, argv, 7 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N+k, strideY, argv, 5 );
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N+((k>0)?k:0), strideY, argv, 5 );
API_SUFFIX(stdlib_strided_sright_pad_circular_ndarray)( N, k, X, strideX, offsetX, Y, strideY, offsetY );
return NULL;
}
Expand Down
Loading