Repository navigation
fix: ensure proper length calculation and fix typos - #16171
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G1zfAZ7jnW24aMJF7wrDi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G1zfAZ7jnW24aMJF7wrDi
…dleft-pad-circular` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G1zfAZ7jnW24aMJF7wrDi
…sright-pad-circular` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G1zfAZ7jnW24aMJF7wrDi
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Oct 15, 2026
| STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 2 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+k, strideY, argv, 4 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N+((k>0)?k:0), strideY, argv, 4 ); |
Member
There was a problem hiding this comment.
cc @headlessNode This likely applies to edge padding, as well, and any other strided pad API.
Member
There was a problem hiding this comment.
@headlessNode If you can fix your other open PRs, that would be great. Cheers!
kgryte
approved these changes
Oct 15, 2026
develop on 2026-10-14/15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-10-14 12:27 UTC (7b218b1) and 2026-10-15 12:01 UTC (90fa4c6).This pull request:
blas/ext/base/dleft-pad-circular,blas/ext/base/sright-pad-circular(68c3a90): fixesYlength validation insrc/addon.cto check againstN+((k>0)?k:0)in bothaddonandaddon_method. PreviouslyYwas validated againstN+k, but the kernel clamps negativekto 0 and writesNelements, so, e.g.,N=4,k=-3accepted a 1-elementYand wrote out of bounds, contradicting the documentedN + max(0,k)requirement.blas/ext/base/ndarray/dediff,blas/ext/base/ndarray/sediff(9461887): removes stray "to" from theprepend/appendnotes inREADME.md. The notes now read "values to prepend/append after computing differences", consistent withndarray/gediffand strideddediff.Related Issues
No.
Questions
blas/ext/base/sleft-pad-circular/src/addon.cpredates the review window and has the sameN+kvalidation; left untouched here. Same fix applies if we want it.Other
Validation
68c3a90) for stdlib style-guide compliance against reference packages (dwxpy,zwxpy,dtril2triu,dcartesian-power,gindex-of-less-than-equal,gleft-pad-circular, etc.) and for bugs in introduced JS/C code, addons, manifests, namespaces, and TypeScript declarations.develop.xdatavsdataXinndarray/cwxsy, extra blank lines inndarray/zwxsy/ndarray/cwxsy).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated daily review of commits merged to
develop. Opened as a draft for maintainer audit.🤖 Generated with Claude Code
https://claude.ai/code/session_014G1zfAZ7jnW24aMJF7wrDi
Generated by Claude Code