Repository navigation
Conversation
`1 - p` rounds away the low-order bits of `p`, and all of them for `p < 2^-53`, where the function returned `0`. The fixtures are now generated from the textbook formula in extended precision.
5 of 7 tasks
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
0PrashantYadav0
approved these changes
Oct 7, 2026
| lambda = smallP.lambda; | ||
| k = smallP.k; | ||
| for ( i = 0; i < p.length; i++ ) { | ||
| y = quantile( p[i], k[i], lambda[i] ); |
Member
There was a problem hiding this comment.
Suggested change
| y = quantile( p[i], k[i], lambda[i] ); | |
| y = quantile( p[ i ], k[ i ], lambda[ i ] ); |
Non-blocking: Match the spacing used in the rest of this file. Also move the smallP require (line 33) below largeShape, as in test.quantile.js and test.factory.js.
Contributor
Author
There was a problem hiding this comment.
Done in 45ec184: the call now uses p[ i ], k[ i ] and lambda[ i ], and smallP is required after largeShape, matching test.quantile.js and test.factory.js.
…/weibull/quantile`
0PrashantYadav0
approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
-log1p( -p )instead of-ln( 1.0 - p )instats/base/dists/weibull/quantile(JS, factory and C).Forming
1 - pin double precision rounds away the low-order bits ofp. Forp < 2^-53it rounds to1, so the function returns0:For
pbetween2^-53and about1e-8,developreturns a value with only a few correct digits. Forp >= 0.5,1 - pis exact, so nothing changes there.Changes to the fixtures:
runner.jlnow evaluates the textbook formulalambda * (-ln(1-p))^(1/k)in 2048-bitBigFloatinstead of callingDistributions.quantile. Distributions computes the same-log(1-p)in double precision, so the old fixtures reproduced the bug instead of catching it. The three existing fixtures are regenerated with the same input ranges (new random draws).small_p.jsonfixture withplog-spaced over[1e-300, 0.1]. Its shape parameters are1,2,4and8, so1/kis exact and the test measures the error from1 - p. Ondevelop, 997 of the 4,021 assertions intest.quantile.jsfail. With this change they all pass at 1 ULP, in JS and native.Tolerances are the smallest that pass in JS and native.
both_largegoes from 0 to 1 ULP, since the fixture is no longer bit-identical to the implementation's formula.large_scalegoes from 6 to 56 ULP. That fixture has shapes down to about0.01. Rounding1/kto a double then shifts the result by up to|ln(-ln(1-p))| / kULP.develophas the same error against the exact values, so this isn't a regression; the old fixture hid it because it used the same double-precision formula.Related Issues
None.
Questions
The same
ln( 1.0 - p )pattern is inexponential/quantileand, aspow( 1.0-p, 1.0/b ), inkumaraswamy/quantile. I can send those as separate PRs.Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. I found the bug by reading the
stats/base/distsquantile functions for1 - pcancellation.@stdlib-js/reviewers