Repository navigation
Conversation
…ile` `1 - p` rounds away the low-order bits of `p`, and all of them for `p < 2^-53`, where the function returned `0`.
5 of 7 tasks
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This was referenced Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
-log1p( -p )instead of-ln( 1.0 - p )instats/base/dists/exponential/quantile(JS, factory and C).Forming
1 - pin double precision rounds away the low-order bits ofp. Forp < 2^-53it rounds to1, so the function returns0:This is also why the existing R fixture needed a 172-ULP tolerance. R's
qexpuses-log1p(-p) / rate, so with this change the same fixture passes at 2 ULP.Tests:
test.quantile.js,test.factory.jsandtest.native.js.test/fixtures/julia/small_p.jsonwithplog-spaced over[1e-300, 0.1].runner.jlevaluates the textbook formula-ln(1-p) / lambdain 2048-bitBigFloat. It passes at 1 ULP in JS and native.develop, 1,085 of the 2,013 assertions intest.quantile.jsfail. With this change they all pass.Related Issues
None. Same bug as #15762 (
weibull/quantile).Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code. I found the bug by reading the
stats/base/distsquantile functions for1 - pcancellation.@stdlib-js/reviewers