Repository navigation
fix: support full 64-bit integer range for number inputs in int64/ctor - #15477
Merged
Merged
Conversation
Member
Author
|
Depends on #15475 |
6 of 7 tasks
kgryte
reviewed
Sep 24, 2026
| var MIN_SAFE_INTEGER = require( '@stdlib/constants/float64/min-safe-integer' ); | ||
| var format = require( '@stdlib/string/format' ); | ||
| var ToPrimitiveSymbol = require( '@stdlib/symbol/to-primitive' ); | ||
| var bigint2words = require( '@stdlib/number/uint64/base/bigint2words' ).assign; |
Member
There was a problem hiding this comment.
@impawstarlight Should we go ahead and add int64/base/bigint2words?
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Sep 24, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Sep 24, 2026
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Sep 24, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none.
Description
This pull request:
Int64constructor to allow unsafe integers of magnitude upto2^64-1.Related Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A.
@stdlib-js/reviewers