Skip to content

feat: add number/int64/base/number2words - #15475

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/int64-base-number2words
Sep 24, 2026
Merged

feat: add number/int64/base/number2words#15475
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/int64-base-number2words

Conversation

@impawstarlight

@impawstarlight impawstarlight commented Sep 23, 2026

Copy link
Copy Markdown
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a package for splitting number values into high and low 32-bit words of a 64-bit signed integer.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This package was primarily written by Antigravity (Gemini) with uint64/base/number2words as the reference.

@stdlib-js/reviewers

@impawstarlight
feat: add number/int64/base/number2words
4110b47 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@impawstarlight
impawstarlight requested a review from a team September 23, 2026 21:59
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 23, 2026
@impawstarlight impawstarlight added the Feature Issue or pull request for adding a new feature. label Sep 23, 2026
@stdlib-bot

stdlib-bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/int64/base/number2words $\\color{green}161/161$
$\\color{green}+0.00\\%$ 		$\\color{green}5/5$
$\\color{green}+0.00\\%$ 		$\\color{green}2/2$
$\\color{green}+0.00\\%$ 		$\\color{green}161/161$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@impawstarlight impawstarlight mentioned this pull request Sep 23, 2026
Merged
2 of 7 tasks
@impawstarlight

impawstarlight commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@DivitJain26 You can proceed with refactoring the splitting logic in hasEqualValues to use this package once it is merged. For reference usage see #15477.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 24, 2026
kgryte
kgryte reviewed Sep 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int64/base/number2words/test/test.assign.js Outdated
kgryte
kgryte reviewed Sep 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int64/base/number2words/test/test.assign.js Outdated
@kgryte
Apply batched suggestions from code review
a554b73 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Sep 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int64/base/number2words/README.md Outdated
@kgryte
docs: update note
71e01c7 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Sep 24, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int64/base/number2words/README.md Outdated
@kgryte
docs: update note
f66e19f 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Sep 24, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit c96ecd5 into stdlib-js:develop Sep 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@impawstarlight @stdlib-bot @kgryte