Skip to content

test: migrate math/base/special/digamma to ULP-based assertions #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
Aug 28, 2026
Merged

test: migrate math/base/special/digamma to ULP-based assertions #14717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eff821e
test: migrate math/base/special/digamma to ULP-based assertions
aryan7071 Aug 27, 2026
d8f434e
Apply batched suggestions from code review
kgryte Aug 28, 2026
bdfed20
test: fix bracket
kgryte Aug 28, 2026
c6e4aba
test: fix bracket
kgryte Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/digamma/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var tape = require( 'tape' );
var isfinite = require( '@stdlib/math/base/assert/is-finite' );
var isnan = require( '@stdlib/assert/is-nan' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var digamma = require( './../lib' );

Expand All @@ -38,8 +38,7 @@ for ( i = 0; i < expected.length; i++ ) {
v = expected[ i ];
if ( v === 'Inf' ) {
expected[ i ] = PINF;
}
else if ( v === 'NaN' ) {
} else if ( v === 'NaN' ) {
expected[ i ] = NaN;
}
}
Expand Down Expand Up @@ -81,7 +80,7 @@ tape( 'the function evaluates the digamma function', function test( t ) {
b2 = isnan( expected[ i ] );
t.strictEqual( b1, b2, 'returned result is ' + ( (b1) ? '' : 'not' ) + ' NaN' );
if ( !b1 ) {
t.ok( abs( actual - expected[ i ] ) < 1.0e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected[ i ] + '.' );
t.strictEqual( isAlmostSameValue( actual, expected[ i ], 82 ), true, 'returns expected value' );
}
}
t.end();
Expand All @@ -96,6 +95,6 @@ tape( 'the function evaluates the digamma function for `x` such that remainder >
expected = -2.863183589156929;
actual = digamma( x );

t.ok( abs( actual - expected ) < 1.0e-14, 'returned result within tolerance' );
t.strictEqual( isAlmostSameValue( actual, expected, 82 ), true, 'returns expected value' );
t.end();
});
9 changes: 4 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isfinite = require( '@stdlib/math/base/assert/is-finite' );
var isnan = require( '@stdlib/assert/is-nan' );
var abs = require( '@stdlib/math/base/special/abs' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var PINF = require( '@stdlib/constants/float64/pinf' );
var tryRequire = require( '@stdlib/utils/try-require' );

Expand All @@ -47,8 +47,7 @@ for ( i = 0; i < expected.length; i++ ) {
v = expected[ i ];
if ( v === 'Inf' ) {
expected[ i ] = PINF;
}
else if ( v === 'NaN' ) {
} else if ( v === 'NaN' ) {
expected[ i ] = NaN;
}
}
Expand Down Expand Up @@ -90,7 +89,7 @@ tape( 'the function evaluates the digamma function', opts, function test( t ) {
b2 = isnan( expected[ i ] );
t.strictEqual( b1, b2, 'returned result is ' + ( (b1) ? '' : 'not' ) + ' NaN' );
if ( !b1 ) {
t.ok( abs( actual - expected[ i ] ) < 1.0e-14, 'returned result is within tolerance. actual: ' + actual + '; expected: ' + expected[ i ] + '.' );
t.strictEqual( isAlmostSameValue( actual, expected[ i ], 82 ), true, 'returns expected value' );
}
}
t.end();
Expand All @@ -105,6 +104,6 @@ tape( 'the function evaluates the digamma function for `x` such that remainder >
expected = -2.863183589156929;
actual = digamma( x );

t.ok( abs( actual - expected ) < 1.0e-14, 'returned result within tolerance' );
t.strictEqual( isAlmostSameValue( actual, expected, 82 ), true, 'returns expected value' );
t.end();
});