Skip to content

test: migrate math/base/special/digamma to ULP-based assertions - #14717

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
aryan7071:test-migrate-digamma
Aug 28, 2026
Merged

kgryte merged 4 commits into
stdlib-js:developfrom
aryan7071:test-migrate-digamma

Conversation

@aryan7071

Copy link
Copy Markdown
Contributor

Resolves a part of #11352

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js of math/base/special/digamma from relative tolerance (EPS-based) assertions to ULP difference assertions via @stdlib/assert/is-almost-same-value.
  • replaces the direct t.ok( ... ) tolerance-based assertion with t.strictEqual( isAlmostSameValue( actual, expected[ i ], 82 ), true, 'returns expected value' ).
  • removes the now-unused abs require.
  • The final ULP value required for both the JavaScript and native implementations is 82.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@aryan7071
aryan7071 requested a review from a team August 27, 2026 16:58
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 27, 2026
@stdlib-bot

stdlib-bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/digamma $\\color{red}525/532$
$\\color{green}+0.00\\%$
$\\color{red}32/35$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{red}525/532$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title test: migrate math/base/special/digamma to ULP-based assertions test: migrate math/base/special/digamma to ULP-based assertions Aug 27, 2026
@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Needs Review A pull request which needs code review. labels Aug 27, 2026
Comment thread lib/node_modules/@stdlib/math/base/special/digamma/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/digamma/test/test.native.js Outdated
kgryte added 3 commits August 27, 2026 17:02
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels Aug 28, 2026
@kgryte
kgryte merged commit f29caab into stdlib-js:develop Aug 28, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants