Skip to content

bench: fix description and update variable names in blas/base/ndarray - #14261

Merged
kgryte merged 1 commit into
developfrom
claude/ecstatic-heisenberg-c51e9k
Aug 14, 2026
Merged

kgryte merged 1 commit into
developfrom
claude/ecstatic-heisenberg-c51e9k

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-08-13 and 2026-08-14 to sibling packages.

Same defect propagates through the level-2/level-3 blas/base/ndarray matrix benchmarks (cgemv, dgemm, dgemv, dger, dspr, dsyr, dsyr2, ggemm, ggemv, gger, gsyr, sgemm, sgemv, sger, sspr, ssyr, ssyr2): benchmark factories document len as array length when it is the matrix dimension, and labels report len=%d rather than size=%d per docs/contributing/benchmark_names.md. Rename len to N in each benchmark/benchmark.js, correct the JSDoc to "number of elements along each dimension", and switch labels to size=%d using N*N for dense routines or ( N * ( N+1 ) ) / 2 for packed routines (dspr, sspr), bringing these ndarray variants in line with their already-migrated blas/base/* counterparts.

Source commit: d0d285717b (bench: fix description and update variable names). Target packages:

  • @stdlib/blas/base/ndarray/cgemv
  • @stdlib/blas/base/ndarray/dgemm
  • @stdlib/blas/base/ndarray/dgemv
  • @stdlib/blas/base/ndarray/dger
  • @stdlib/blas/base/ndarray/dspr
  • @stdlib/blas/base/ndarray/dsyr
  • @stdlib/blas/base/ndarray/dsyr2
  • @stdlib/blas/base/ndarray/ggemm
  • @stdlib/blas/base/ndarray/ggemv
  • @stdlib/blas/base/ndarray/gger
  • @stdlib/blas/base/ndarray/gsyr
  • @stdlib/blas/base/ndarray/sgemm
  • @stdlib/blas/base/ndarray/sgemv
  • @stdlib/blas/base/ndarray/sger
  • @stdlib/blas/base/ndarray/sspr
  • @stdlib/blas/base/ndarray/ssyr
  • @stdlib/blas/base/ndarray/ssyr2

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: candidate sites were enumerated by searching all benchmark files for len=%d labels co-occurring with N×N matrix construction; two independent validation passes confirmed the defect at each site by reading each original file in full, an adaptation pass verified the per-site size expressions (dense vs. packed storage, complex interleaved buffers), and a style pass checked declaration ordering, label naming per docs/contributing/benchmark_names.md, and JSDoc wording against the source commit and already-migrated blas/base/* counterparts. Deliberately excluded: benchmark.length.js files for cartesian-product-style packages (label semantics differ), level-1 vector routines (where len=%d is correct), and BLAS-level blas/base/*gemm/*ger files (already migrated to size=%d).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code as part of an automated fix-propagation routine: it applies the fix from commit d0d285717b to sibling packages, with each target site validated by independent review passes before inclusion.


Generated by Claude Code

Propagates fix from d0d2857 ("bench: fix description and update
variable names") to sibling matrix benchmarks in `blas/base/ndarray`
with the same mislabeled workload size: the benchmark factory parameter
was documented as an array length while being the matrix dimension, and
benchmark labels reported the dimension via `len=%d` rather than the
element count via `size=%d`.

Affected packages: cgemv, dgemm, dgemv, dger, dspr, dsyr, dsyr2, ggemm,
ggemv, gger, gsyr, sgemm, sgemv, sger, sspr, ssyr, ssyr2.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013Z4Xtpa7cD9BHHLV96uPcg
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 14, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/ndarray/cgemv $\\color{green}169/169$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}169/169$
$\\color{green}+100.00\\%$
blas/base/ndarray/dgemm $\\color{green}197/197$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}197/197$
$\\color{green}+100.00\\%$
blas/base/ndarray/dgemv $\\color{green}167/167$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}167/167$
$\\color{green}+100.00\\%$
blas/base/ndarray/dger $\\color{green}147/147$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}147/147$
$\\color{green}+100.00\\%$
blas/base/ndarray/dspr $\\color{green}146/146$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}146/146$
$\\color{green}+100.00\\%$
blas/base/ndarray/dsyr $\\color{green}151/151$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}151/151$
$\\color{green}+100.00\\%$
blas/base/ndarray/dsyr2 $\\color{green}156/156$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}156/156$
$\\color{green}+100.00\\%$
blas/base/ndarray/ggemm $\\color{green}197/197$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}197/197$
$\\color{green}+100.00\\%$
blas/base/ndarray/ggemv $\\color{green}167/167$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}167/167$
$\\color{green}+100.00\\%$
blas/base/ndarray/gger $\\color{green}147/147$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}147/147$
$\\color{green}+100.00\\%$
blas/base/ndarray/gsyr $\\color{green}147/147$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}147/147$
$\\color{green}+100.00\\%$
blas/base/ndarray/sgemm $\\color{green}197/197$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}197/197$
$\\color{green}+100.00\\%$
blas/base/ndarray/sgemv $\\color{green}167/167$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}167/167$
$\\color{green}+100.00\\%$
blas/base/ndarray/sger $\\color{green}147/147$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}147/147$
$\\color{green}+100.00\\%$
blas/base/ndarray/sspr $\\color{green}146/146$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}146/146$
$\\color{green}+100.00\\%$
blas/base/ndarray/ssyr $\\color{green}151/151$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}151/151$
$\\color{green}+100.00\\%$
blas/base/ndarray/ssyr2 $\\color{green}156/156$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}156/156$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 14, 2026 19:48
@Planeshifter
Planeshifter requested review from a team and kgryte August 14, 2026 19:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 14, 2026
@kgryte
kgryte merged commit 75cbfe8 into develop Aug 14, 2026
53 checks passed
@kgryte
kgryte deleted the claude/ecstatic-heisenberg-c51e9k branch August 14, 2026 20:55
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 14, 2026
@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Aug 14, 2026
@Planeshifter Planeshifter mentioned this pull request Aug 15, 2026
4 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants