Skip to content

chore: clean-up - #14292

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-08-15
Aug 15, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-08-15

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

> What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-08-14 and 2026-08-15 to sibling packages.

Source commit a99a888 (docs: fix typo) corrected probablity to probability in stats/base/dists/geometric/variance/src/main.c but left the identical string in the package README, which documents the same C API parameter. That README line was the last occurrence of probablity anywhere in the repository; fixing it brings the file in line with all eight sibling stats/base/dists/geometric/* READMEs, which already read "success probability". Target package:

  • @stdlib/stats/base/dists/geometric/variance

blas/base/ndarray/ssymv (added in 26e6545 after PR #14261's len → N cleanup was authored) shipped with the same stale template: len documented as "array length" for a parameter that is actually the dense N-by-N symmetric matrix dimension, plus a len=%d benchmark label reporting the wrong problem size. This commit applies the identical fix from source commit 75cbfe8 (bench: fix description and update variable names in blas/base/ndarray) — rename len to N, correct the JSDoc to "number of elements along each dimension", and switch the label to %s:size=%d reporting N*N — bringing ssymv in line with ssyr, sgemv, and the rest of the blas/base/ndarray matrix-op benchmarks. With this change, every matrix-op benchmark in blas/base/ndarray follows the docs/contributing/benchmark_names.md convention. Target package:

  • @stdlib/blas/base/ndarray/ssymv

Related Issues

> Does this pull request have any related issues?

No.

Questions

> Any questions for reviewers of this pull request?

No.

Other

> Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: candidate sites were enumerated per source pattern (repo-wide probablity search with a single remaining hit; %s:len=%d labels co-occurring with two-dimensional allocations across blas/base/ndarray/*/benchmark/, where the 40 remaining len=%d files are level-1 vector routines for which len is correct terminology). Two independent validation passes confirmed each defect by reading each target file in full, an adaptation pass verified the dense (N*N) versus packed (( N * ( N+1 ) ) / 2) size expression and the declaration ordering against the fixed siblings, and a style pass checked wording against the eight sibling geometric/* READMEs and the fixed ssyr/sgemv benchmarks. Deliberately excluded: three additional source patterns from the window (stale README variable note from 8d4d135, missing ComplexLike JSDoc types from ee85255, missing Cephes install step from 7f74364) after exhaustive searches found no remaining sibling defects.

Checklist

> Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

> When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

> If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code as part of an automated fix-propagation routine: it applies fixes from commits a99a888 and 75cbfe8 to sibling packages, with each target site validated by independent review passes before inclusion.


Generated by Claude Code

claude added 2 commits August 15, 2026 13:22
Propagates fix from a99a888 ("docs: fix typo") to the package README,
which documents the same C API parameter and retained the misspelling
corrected in `src/main.c`.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RDPteKXsG9t8kxHKjbrAif
Propagates fix from 75cbfe8 ("bench: fix description and update
variable names in `blas/base/ndarray`") to the `ssymv` package, which
was added after that fix landed and retained the same benchmark
pattern: `len` documented as "array length" for a dense N-by-N matrix
operation and a `len=%d` label instead of `size=%d` with the total
problem size.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RDPteKXsG9t8kxHKjbrAif
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 15, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/ndarray/ssymv $\\color{green}165/165$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}165/165$
$\\color{green}+100.00\\%$
stats/base/dists/geometric/variance $\\color{green}165/165$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}165/165$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 15, 2026 22:36
@kgryte
kgryte requested a review from a team August 15, 2026 22:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 15, 2026
@kgryte kgryte changed the title docs: fix typo in geometric/variance and bench labels in ssymv chore: clean-up Aug 15, 2026
@kgryte
kgryte merged commit 448c54b into develop Aug 15, 2026
45 checks passed
@kgryte
kgryte deleted the philipp/fix-propagation-2026-08-15 branch August 15, 2026 22:37
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Documentation Improvements, additions, or changes to documentation. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants