Skip to content

chore: clean-up - #14138

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-08-10
Aug 10, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-08-10

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-08-09 13:57 (-0700) and 2026-08-10 05:41 (-0700) to sibling packages with the same underlying defects.

Copy-paste parameter mislabels in pareto-type1 C docs

af0c6b6 fixed doxygen @param copy-paste residue in lognormal/kurtosis; the same defect recurs in pareto-type1/skewness and pareto-type1/stdev, where src/main.c and the README C section call alpha a "first shape parameter" and beta a "second shape parameter", contradicting the JS docblocks and the other ten pareto-type1 C implementations. alpha is the shape parameter, beta is the scale parameter — relabeled in both files, both packages.

Stack-based VLAs in benchmark code

Commit 3208321 (bench: refactor to use dynamic memory allocation, #14099) converted stack-allocated variable-length arrays to heap allocation across 13 blas/base, blas/ext/base, and lapack/base benchmarks; blas/base/zaxpy/benchmark/c/benchmark.length.c was missed. This PR applies the same conversion there: x/y become pointers, malloc after the alpha assignment, free before return, timed region untouched. Pattern modeled on zscal from the source commit; no runtime-sized VLAs remain in the tree.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed before inclusion: candidate sites were enumerated by comparing C @param descriptions against each package's own JS docblocks across stats/base/dists/*/* and by scanning all benchmark*.c for runtime-sized stack arrays; each surviving site was independently confirmed by two validation passes, an adaptation pass producing the exact per-site patch, and a style-consistency pass against sibling packages.

Deliberately excluded: lognormal/logcdf (same defect class — mu/sigma documented as "mean"/"standard deviation" in src/main.c, README C section, and header — but the fix's scope over summary sentences is a maintainer call, since siblings split between "location parameter mu" and "location mu" phrasings); five misspelled-but-semantically-correct descriptions ("scale paramter" in pareto-type1/{entropy,variance} and weibull/{entropy,variance}, "success probablity" in geometric/variance), which are a separate spelling-defect class rather than analogs of af0c6b6; and negative-binomial/variance, where the package's own docs disagree on whether r counts successes or failures.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled fix-propagation routine: it identified fix commits merged to develop in the last 24 hours, located sibling packages with the same defects, and applied the equivalent fixes after multi-pass validation.

🤖 Generated with Claude Code

https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ


Generated by Claude Code

claude added 2 commits August 10, 2026 13:27
Propagates fix from af0c6b6 ("docs: fix C API parameter descriptions")
to sibling packages documenting the Pareto (Type I) scale parameter
`beta` as a "second shape parameter" in C API docs.

Affected packages:

-   `stats/base/dists/pareto-type1/skewness`
-   `stats/base/dists/pareto-type1/stdev`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ
Propagates fix from 3208321 ("bench: refactor to use dynamic memory
allocation") to the last remaining C benchmark declaring runtime-sized
variable-length arrays on the stack.

Ref: #8643

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/zaxpy $\\color{green}417/417$
$\\color{green}+100.00\\%$
$\\color{green}18/18$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}417/417$
$\\color{green}+100.00\\%$
stats/base/dists/pareto-type1/skewness $\\color{green}196/196$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}196/196$
$\\color{green}+100.00\\%$
stats/base/dists/pareto-type1/stdev $\\color{green}188/188$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}188/188$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 10, 2026 20:53
@kgryte
kgryte requested a review from a team August 10, 2026 20:53
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 10, 2026
@kgryte kgryte changed the title docs: propagate fixes to pareto-type1 and blas/base/zaxpy chore: clean-up Aug 10, 2026
@kgryte
kgryte merged commit ccc3c46 into develop Aug 10, 2026
54 checks passed
@kgryte
kgryte deleted the philipp/fix-propagation-2026-08-10 branch August 10, 2026 20:53
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 10, 2026
@Planeshifter Planeshifter mentioned this pull request Aug 15, 2026
4 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants