Repository navigation
chore: clean-up - #14138
chore: clean-up#14138
Conversation
Propagates fix from af0c6b6 ("docs: fix C API parameter descriptions") to sibling packages documenting the Pareto (Type I) scale parameter `beta` as a "second shape parameter" in C API docs. Affected packages: - `stats/base/dists/pareto-type1/skewness` - `stats/base/dists/pareto-type1/stdev` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ
Propagates fix from 3208321 ("bench: refactor to use dynamic memory allocation") to the last remaining C benchmark declaring runtime-sized variable-length arrays on the stack. Ref: #8643 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
pareto-type1 and blas/base/zaxpy
Description
This pull request:
developbetween 2026-08-09 13:57 (-0700) and 2026-08-10 05:41 (-0700) to sibling packages with the same underlying defects.Copy-paste parameter mislabels in pareto-type1 C docs
af0c6b6 fixed doxygen
@paramcopy-paste residue inlognormal/kurtosis; the same defect recurs inpareto-type1/skewnessandpareto-type1/stdev, wheresrc/main.cand the README C section callalphaa "first shape parameter" andbetaa "second shape parameter", contradicting the JS docblocks and the other tenpareto-type1C implementations.alphais the shape parameter,betais the scale parameter — relabeled in both files, both packages.Stack-based VLAs in benchmark code
Commit 3208321 (
bench: refactor to use dynamic memory allocation, #14099) converted stack-allocated variable-length arrays to heap allocation across 13blas/base,blas/ext/base, andlapack/basebenchmarks;blas/base/zaxpy/benchmark/c/benchmark.length.cwas missed. This PR applies the same conversion there:x/ybecome pointers,mallocafter the alpha assignment,freebefore return, timed region untouched. Pattern modeled onzscalfrom the source commit; no runtime-sized VLAs remain in the tree.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Validation performed before inclusion: candidate sites were enumerated by comparing C
@paramdescriptions against each package's own JS docblocks acrossstats/base/dists/*/*and by scanning allbenchmark*.cfor runtime-sized stack arrays; each surviving site was independently confirmed by two validation passes, an adaptation pass producing the exact per-site patch, and a style-consistency pass against sibling packages.Deliberately excluded:
lognormal/logcdf(same defect class —mu/sigmadocumented as "mean"/"standard deviation" insrc/main.c, README C section, and header — but the fix's scope over summary sentences is a maintainer call, since siblings split between "location parametermu" and "locationmu" phrasings); five misspelled-but-semantically-correct descriptions ("scale paramter" inpareto-type1/{entropy,variance}andweibull/{entropy,variance}, "success probablity" ingeometric/variance), which are a separate spelling-defect class rather than analogs of af0c6b6; andnegative-binomial/variance, where the package's own docs disagree on whetherrcounts successes or failures.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled fix-propagation routine: it identified fix commits merged to
developin the last 24 hours, located sibling packages with the same defects, and applied the equivalent fixes after multi-pass validation.🤖 Generated with Claude Code
https://claude.ai/code/session_019RjECpzDmZvZKwosPjWkTJ
Generated by Claude Code