Skip to content

docs: add Git note #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Aug 6, 2026
Merged

docs: add Git note #13981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
976edfb
docs: add Git note for commit 1d04bde8494e00ba85be2fe9a20939c892bb173b
Planeshifter Aug 6, 2026
30594c2
Apply suggestions from code review
kgryte Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/git-notes/1d04bde8494e00ba85be2fe9a20939c892bb173b.txt
View file
Open in desktop

@kgryte kgryte Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This commit (ref: 1d04bde) should never have included an agent as a co-author. You cannot rely on the automation workflow to generate the commit message for this.

@Planeshifter Planeshifter Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this. To clarify the scope of this PR: the automated git-notes audit only fixes a malformed trailer in the original commit — Co-authored-by: Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> had the key duplicated inside the value, which is a syntax defect. The audit's guardrails restrict it to clear, mechanical errors (typos, broken trailers, wrong PR/issue references) and explicitly disallow it from making judgment calls, so it preserved the underlying Co-authored-by: Claude Opus 5 <...> and Co-authored-by: kgryte <...> attributions as they appeared in the original commit rather than removing them.

Whether an agent should be listed as a co-author on commits like this one is a workflow-policy question about how commit messages get generated upstream of this audit, not something this PR (or I) should decide unilaterally. I've flagged it to @Planeshifter for a decision.

Generated by Claude Code

@kgryte kgryte Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the 2774 reference is unnecessary. Maybe I should just buy you a license for Keyboard Maestro, as the workflow is faster, wastes less resources, and is more explicit.

@kgryte kgryte Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole automation workflow only works if there is a human actually verifying the generated proposed commit messages which it doesn't look like there was for this PR.

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
type: amend-message
---
test: migrate `math/base/special/factorialln` to ULP-based assertions

PR-URL: https://github.com/stdlib-js/stdlib/pull/13962
Ref: https://github.com/stdlib-js/stdlib/issues/11352

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>