Skip to content

docs: add Git note - #13981

Merged
kgryte merged 2 commits into
developfrom
philipp/git-notes-20260806
Aug 6, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/git-notes-20260806

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds a docs/git-notes/ correction note for one commit merged to develop in the last 24 hours whose message had a malformed trailer, found by an automated audit of recent commit messages.

The following commit is amended:

  • 1d04bde84: malformed Co-authored-by trailer — the original reads Co-authored-by: Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (the key is duplicated inside the value). The note corrects it to Co-authored-by: Claude Opus 5 <noreply@anthropic.com>, preserving the second Co-authored-by: kgryte <kgryte+claude@gmail.com> trailer and all other trailers (PR-URL, both Ref: lines, Reviewed-by) unchanged. PR-URL and both Ref issue/PR numbers were independently verified against GitHub and are correct, so nothing else needed fixing.

No other commits from the last 24 hours were flagged — all other PR-URL/Closes/Ref references were spot-checked against GitHub and matched, and no spelling, grammar, or Conventional Commits style violations were found.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running as an unattended scheduled task, auditing commit messages merged to develop in the last 24 hours and adding a correction note under docs/git-notes/.


@stdlib-js/reviewers


Generated by Claude Code

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This commit (ref: 1d04bde) should never have included an agent as a co-author. You cannot rely on the automation workflow to generate the commit message for this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this. To clarify the scope of this PR: the automated git-notes audit only fixes a malformed trailer in the original commit — Co-authored-by: Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> had the key duplicated inside the value, which is a syntax defect. The audit's guardrails restrict it to clear, mechanical errors (typos, broken trailers, wrong PR/issue references) and explicitly disallow it from making judgment calls, so it preserved the underlying Co-authored-by: Claude Opus 5 <...> and Co-authored-by: kgryte <...> attributions as they appeared in the original commit rather than removing them.

Whether an agent should be listed as a co-author on commits like this one is a workflow-policy question about how commit messages get generated upstream of this audit, not something this PR (or I) should decide unilaterally. I've flagged it to @Planeshifter for a decision.


Generated by Claude Code

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the 2774 reference is unnecessary. Maybe I should just buy you a license for Keyboard Maestro, as the workflow is faster, wastes less resources, and is more explicit.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole automation workflow only works if there is a human actually verifying the generated proposed commit messages which it doesn't look like there was for this PR.

Comment thread docs/git-notes/1d04bde8494e00ba85be2fe9a20939c892bb173b.txt Outdated
Comment thread docs/git-notes/1d04bde8494e00ba85be2fe9a20939c892bb173b.txt Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte marked this pull request as ready for review August 6, 2026 16:19
@kgryte
kgryte requested a review from a team August 6, 2026 16:19
@kgryte kgryte changed the title docs: add Git notes correcting recent commit messages docs: add Git note Aug 6, 2026
@kgryte
kgryte merged commit 09ce345 into develop Aug 6, 2026
11 checks passed
@kgryte
kgryte deleted the philipp/git-notes-20260806 branch August 6, 2026 16:19
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants