Skip to content

test: migrate math/base/special/log1pmx to ULP-based testing - #13979

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1pmx-ulp
Aug 6, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1pmx-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the math/base/special/log1pmx test file from relative tolerance testing to ULP difference testing.
  • Adds the @stdlib/assert/is-almost-same-value assertion and replaces the delta = abs( actual - expected ), tol = 100.0 * EPS * abs( expected ) tolerance checks with t.strictEqual( isAlmostSameValue( actual, expected, 9 ), true, 'returns expected value' ) using the minimum required ULP value of 9.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

N/A


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team August 6, 2026 13:54
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 6, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@ujjwalv01

Copy link
Copy Markdown
Member Author

This package has a native C implementation (lib/native.js and src/addon.c), but test/test.native.js does not exist yet. Should a test.native.js be added as part of this PR?

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/log1pmx $\\color{green}207/207$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}207/207$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 6, 2026
@kgryte

kgryte commented Aug 6, 2026

Copy link
Copy Markdown
Member

Should a test.native.js be added as part of this PR?

@ujjwalv01 Would you mind adding in a follow-up PR? Cheers!

@kgryte
kgryte merged commit 4d3ec88 into stdlib-js:develop Aug 6, 2026
116 checks passed
kgryte pushed a commit that referenced this pull request Aug 7, 2026
PR-URL: #14010
Reviewed-by: Athan Reines <kgryte@gmail.com>
Ref: #11352
Ref: #13979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants