Skip to content

test: add native add-on tests to math/base/special/log1pmx - #14010

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1pmx-test-native
Aug 7, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-log1pmx-test-native

Conversation

@ujjwalv01

Copy link
Copy Markdown
Member

Resolves part of #11352

Description

What is the purpose of this pull request?

This pull request:

  • Adds test.native.js to @stdlib/math/base/special/log1pmx to execute unit tests for the package's C native addon implementation, mirroring the test assertions in the primary test.js file.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team August 7, 2026 10:13
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 7, 2026
kgryte
kgryte previously approved these changes Aug 7, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ujjwalv01!

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 7, 2026
@kgryte

kgryte commented Aug 7, 2026

Copy link
Copy Markdown
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Aug 7, 2026
@stdlib-bot

stdlib-bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/log1pmx $\\color{green}269/269$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}269/269$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Aug 7, 2026
@kgryte kgryte changed the title test: add test.native.js to math/base/special/log1pmx with ULP-based assertion test: add native add-on tests to math/base/special/log1pmx Aug 7, 2026
@kgryte
kgryte merged commit 5a60395 into stdlib-js:develop Aug 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants