feat: add `stats/incr/nanwmean` by Arjan-P · Pull Request #13609 · stdlib-js/stdlib

Arjan-P · 2026-07-22T08:24:47Z

Description

What is the purpose of this pull request?

This pull request:

add incremental accumulators for handling NaN values in stats/incr/nanwmean

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: add stats/incr/nanwmean #5628

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Generated package.json, repl.txt from gemini

@stdlib-js/reviewers

stdlib-bot · 2026-07-22T08:28:48Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanwmean	$\\color{green}135/135$ $\\color{green}+0.00\\%$	$\\color{green}8/8$ $\\color{green}+0.00\\%$	$\\color{green}2/2$ $\\color{green}+0.00\\%$	$\\color{green}135/135$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Neerajpathak07 · 2026-07-22T12:43:44Z

/stdlib update-copyright-years

Neerajpathak07

@Arjan-P Thanks for the PR!! Left out a few comments. Commonly we want to prevent a straight away copy-paste between subsequent packages and think a bit more on what is the true intention and nature of nanwmean being added here.

Arjan-P · 2026-07-22T13:34:40Z

My bad, will be more mindful going forth. I think the package is also missing a README.md. Thank you for the feedback, will address these as soon as possible.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: missing_dependencies - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

- Collapse accumulator guards to the conventional single check; a missing weight now passes through and yields NaN per the wmean/nansumprod convention instead of being silently ignored - Rename inner accumulator variable to 'wmean' per sibling naming - Update missing-weight and NaN tests accordingly; cover NaN in value, weight, and both positions, before and after valid data - Add NaN steps to JSDoc, repl.txt, and index.d.ts examples; fix ungrammatical NaN notes and add missing 'ignoring NaN values' - Rename copied 'incrwmean' identifiers to 'incrnanwmean' in test.ts - Inject NaN values in examples/index.js with guarded printing - Add missing equation placeholder and related-links boilerplate comments to README

Planeshifter

And another one! Let's land it!

Everything addressed.

stdlib-bot · 2026-08-04T06:44:43Z

PR Commit Message

feat: add `stats/incr/nanwmean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/13609
Ref: https://github.com/stdlib-js/stdlib/issues/5628

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Neeraj Pathak <neerajrpathak710@gmail.com>

Please review the above commit message and make any necessary adjustments.

Arjan-P requested a review from a team July 22, 2026 08:24

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jul 22, 2026

Arjan-P changed the title ~~feat; Add stats/incr/nanwmean~~ feat: Add stats/incr/nanwmean Jul 22, 2026

Neerajpathak07 changed the title ~~feat: Add stats/incr/nanwmean~~ feat: add stats/incr/nanwmean Jul 22, 2026

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jul 22, 2026

Neerajpathak07 previously requested changes Jul 22, 2026

View reviewed changes

Neerajpathak07 added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 22, 2026

Arjan-P force-pushed the add-nanwmean branch from bdece4f to 1e0cfc6 Compare July 23, 2026 16:19

Neerajpathak07 added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First PR A pull request resolving a Good First Issue. labels Jul 23, 2026

Arjan-P requested a review from Neerajpathak07 July 23, 2026 17:06

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 23, 2026

Arjan-P and others added 11 commits July 24, 2026 10:41

chore: update copyright years

16b52d2

Arjan-P force-pushed the add-nanwmean branch from 1e0cfc6 to ace6315 Compare July 24, 2026 05:12

Arjan-P requested a review from kgryte July 29, 2026 04:09

Planeshifter mentioned this pull request Aug 4, 2026

Land stats/incr/nan* PRs by Arjan-P stdlib-js/metr-issue-tracker#1108

Closed

Planeshifter approved these changes Aug 4, 2026

View reviewed changes

Planeshifter added the Ready To Merge label Aug 4, 2026

stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Aug 4, 2026

Planeshifter merged commit f2d762e into stdlib-js:develop Aug 4, 2026
32 checks passed

stdlib-bot removed the Ready To Merge label Aug 4, 2026

Arjan-P deleted the add-nanwmean branch August 4, 2026 13:01

This was referenced Aug 9, 2026

feat: add stats/incr/nanwmean #5632

Closed

test: add missing test coverage for stats/incr/nanwmean #9945

Closed

Navigation Menu

Repository navigation

feat: add `stats/incr/nanwmean` - #13609

feat: add `stats/incr/nanwmean`#13609
Planeshifter merged 12 commits into
stdlib-js:developfrom
Arjan-P:add-nanwmean

Arjan-P commented Jul 22, 2026 •

edited

Loading

Uh oh!

stdlib-bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

Neerajpathak07 commented Jul 22, 2026

Uh oh!

Neerajpathak07 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Arjan-P commented Jul 22, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Aug 4, 2026 •

edited by Planeshifter

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Arjan-P commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Neerajpathak07 commented Jul 22, 2026

Uh oh!

Neerajpathak07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Arjan-P commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Aug 4, 2026 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Arjan-P commented Jul 22, 2026 •

edited

Loading

stdlib-bot commented Jul 22, 2026 •

edited

Loading

Arjan-P commented Jul 22, 2026 •

edited

Loading

stdlib-bot commented Aug 4, 2026 •

edited by Planeshifter

Loading