feat: add `stats/incr/nanwmean` by pranav-1720 · Pull Request #5632 · stdlib-js/stdlib

pranav-1720 · 2025-03-01T14:10:43Z

Resolves #5628.

Description

What is the purpose of this pull request?

This pull request:

This Pull request adds the package stats/incr/nanwmean which is a wrapper around stats/incr/wmean to handle NaN values

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-03-01T14:12:18Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanwmean	$\color{green}141/141$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}141/141$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: pranav-1720 <123018993+pranav-1720@users.noreply.github.com>

pranav-1720 · 2025-03-01T15:30:55Z

Hi, almost all the required files have been added to close the issues. I am just unsure what is needed for the repl.txt and image files like which are added in the nansum package. When adding repl.txt, i get module not found errors while commiting. Are these files supposed to be system generated?

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

Planeshifter

In case there is still interest in moving this PR forward, I left some feedback. Sorry it took so long!

Planeshifter · 2026-03-10T00:42:39Z

+// MAIN //
+
+/**
+* Returns an accumulator function which incrementally computes a sum, ignoring `NaN` values.


Says "computes a sum" — should be "weighted arithmetic mean".

Suggested change

* Returns an accumulator function which incrementally computes a sum, ignoring `NaN` values.

* Returns an accumulator function which incrementally computes a weighted arithmetic mean, ignoring `NaN` values.

Planeshifter · 2026-03-10T00:42:41Z

+* mu = accumulator( 3.0, 1.5 );
+* // returns 2.5
+*
+* mu = accumulator (2.0, NaN );


Space before ( — should be accumulator( 2.0, NaN ). Same on line 46 in docs/types/index.d.ts.

Suggested change

* mu = accumulator (2.0, NaN );

* mu = accumulator( 2.0, NaN );

Planeshifter · 2026-03-10T00:42:43Z

+type accumulator = ( x?: number, w?: number ) => number | null;
+
+/**
+* Returns an accumulator function which incrementally computes a weighted arithmetic mean.


Missing "ignoring NaN values".

Suggested change

* Returns an accumulator function which incrementally computes a weighted arithmetic mean.

* Returns an accumulator function which incrementally computes a weighted arithmetic mean, ignoring `NaN` values.

Planeshifter · 2026-03-10T00:42:44Z

This file uses 4-space indentation — stdlib convention is 2-space for JSON files.

anandkaranubc · 2026-08-09T20:08:04Z

Completed here: #13609

stdlib-bot · 2026-08-09T20:08:27Z

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

pranav-1720 added 2 commits March 1, 2025 19:34

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Mar 1, 2025

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 1, 2025

pranav-1720 added 2 commits March 1, 2025 20:58

Update package.json

8fe444f

Signed-off-by: pranav-1720 <123018993+pranav-1720@users.noreply.github.com>

Update package.json

db5eb33

Signed-off-by: pranav-1720 <123018993+pranav-1720@users.noreply.github.com>

ChaitanyaZunzurkar mentioned this pull request Mar 2, 2025

[Add]: Create new package stats/incr/nanwmean to handle NaN values #5743

Closed

5 tasks

stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025

Planeshifter requested changes Mar 10, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026

stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Apr 1, 2026

github-actions Bot mentioned this pull request Apr 1, 2026

[aw] No-Op Runs #11033

Closed

anandkaranubc added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Aug 9, 2026

stdlib-bot closed this Aug 9, 2026

Navigation Menu

Repository navigation

feat: add `stats/incr/nanwmean` - #5632

feat: add `stats/incr/nanwmean`#5632
pranav-1720 wants to merge 5 commits into
stdlib-js:developfrom
pranav-1720:nanwmean

pranav-1720 commented Mar 1, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Mar 1, 2025 •

edited

Loading

Uh oh!

pranav-1720 commented Mar 1, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

anandkaranubc commented Aug 9, 2026

Uh oh!

stdlib-bot commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	* Returns an accumulator function which incrementally computes a sum, ignoring `NaN` values.
	* Returns an accumulator function which incrementally computes a weighted arithmetic mean, ignoring `NaN` values.

	* mu = accumulator (2.0, NaN );
	* mu = accumulator( 2.0, NaN );

Conversation

pranav-1720 commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

pranav-1720 commented Mar 1, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Aug 9, 2026

Uh oh!

stdlib-bot commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pranav-1720 commented Mar 1, 2025 •

edited

Loading

stdlib-bot commented Mar 1, 2025 •

edited

Loading