Skip to content

Add support for macOS and allow building stacks-core from commit hash#39

Open
radu-stacks wants to merge 8 commits into
stacks-network:masterfrom
radu-stacks:feat/mac-os-support
Open

Add support for macOS and allow building stacks-core from commit hash#39
radu-stacks wants to merge 8 commits into
stacks-network:masterfrom
radu-stacks:feat/mac-os-support

Conversation

@radu-stacks
Copy link
Copy Markdown

Continuation of #29 which became stale.

@radu-stacks radu-stacks requested a review from wileyj May 12, 2026 10:28
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 12, 2026

CLA assistant check
All committers have signed the CLA.

@radu-stacks radu-stacks changed the title This PR adds support for macOS and allows building stacks-core from commit hash Add support for macOS and allows building stacks-core from commit hash May 12, 2026
ASuciuX and others added 3 commits May 12, 2026 13:34
@radu-stacks radu-stacks force-pushed the feat/mac-os-support branch from 207ea2f to b78fbfb Compare May 12, 2026 10:34
@radu-stacks
Copy link
Copy Markdown
Author

radu-stacks commented May 12, 2026

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

@radu-stacks radu-stacks changed the title Add support for macOS and allows building stacks-core from commit hash Add support for macOS and allow building stacks-core from commit hash May 12, 2026
Comment thread docker/stacks/Dockerfile
Comment thread docker/docker-compose.yml Outdated
Comment thread Makefile
Comment thread Makefile
Comment thread Makefile
Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Makefile Outdated
@wileyj
Copy link
Copy Markdown
Contributor

wileyj commented May 12, 2026

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

i see @ASuciuX is credited as co-author so it's perfectly fine

@radu-stacks radu-stacks requested a review from wileyj May 24, 2026 19:22
Copy link
Copy Markdown
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants