Fixes for upstream PR 39#1
Merged
radu-stacks merged 3 commits intoMay 24, 2026
Merged
Conversation
Author
|
cc @radu-stacks |
radu-stacks
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed a few comments I had made in stacks-network#39
Makefile here i feel is a little cleaner without relying on all the line escapes, and the version in docker-compose.yml is updated to the latest.
Changes here are confirmed on both Debian and MacOS - not all targets were re-tested, only:
up,down,backup-logsand the helper targets each of them run.