[Defaulttype] TypeInfoRegistry: Fix crash at exit in TypeInfoRegistry deleter#6183
Open
fredroy wants to merge 1 commit into
Open
[Defaulttype] TypeInfoRegistry: Fix crash at exit in TypeInfoRegistry deleter#6183fredroy wants to merge 1 commit into
fredroy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #6182
By Claude:
The root cause is the storage deleter in
TypeInfoRegistry::getStorage(), which callsdelete infoon every stored pointer exceptNoTypeInfo::Get(). However the registry holds two kinds of pointers:NameOnlyTypeInfoobjects it allocates itself withnew(inAllocateNewTypeId) ‚ genuinely heap-owned.Set(), e.g.DataTypeInfoDynamicWrapper<...>::get()(andVirtualTypeInfo<T>::get()used byData::getValueTypeInfo()), which return function-local statics.Deleting those static-storage singletons is undefined behavior (invalid
delete+ double destruction, since the statics also self-destruct via their ownatexithandlers), which triggers the trap. The deleter already special-casedNoTypeInfo::Get()as a singleton but missed that every info registered viaSet()is a singleton too.Fix: Only free what the registry actually allocates:
getStorage()now holds non-owning borrowed pointers (no delete-all deleter).getOwnedStorage()(vector<unique_ptr<const AbstractTypeInfo>>)owns the
NameOnlyTypeInfoobjects created inAllocateNewTypeId.This preserves the leak-free intent of the original deleter (#4838) while never deleting the borrowed static singletons registered through
Set().By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if