Skip to content

[Engine] Rename VolumeFromTetrahedrons to VolumeFromVolumetricElements#6175

Open
alxbilger wants to merge 4 commits into
sofa-framework:masterfrom
alxbilger:renamevolumeengine
Open

[Engine] Rename VolumeFromTetrahedrons to VolumeFromVolumetricElements#6175
alxbilger wants to merge 4 commits into
sofa-framework:masterfrom
alxbilger:renamevolumeengine

Conversation

@alxbilger

@alxbilger alxbilger commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Because it also computes volume from hexas.

The same should be done for VolumeFromTriangles in another PR.

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at renaming, I would suggest to rename this example like VolumeFromVolumetricElements_Tetrahedra. scn or something like that, to keep the (unwritten?) convention: name of scene = name of the component

@alxbilger alxbilger removed the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants