[InterventionalRadiologyController] Fix various potential bugs#236
Open
fredroy wants to merge 8 commits into
Open
[InterventionalRadiologyController] Fix various potential bugs#236fredroy wants to merge 8 commits into
fredroy wants to merge 8 commits into
Conversation
In applyInterventionalRadiologyController() STEP 3, the search for the previous node could leave prev_xId == m_nodeCurvAbs.size() (the "Case 1" path), leading to out-of-bounds reads of m_nodeCurvAbs[prev_xId] and m_idInstrumentCurvAbsTable[prev_xId]. Clamp prev_xId to the last node.
The monotonicity clamp on modifiedNodeCurvAbs started at i > 1, skipping node 1, which could then dip below node 0 (the origin) and feed unsorted curv abscissa into the STEP 3 interpolation. Start the clamp at i > 0.
The loop fixing rigid-segment border nodes could compute firstSimulatedNode + i == numberOfNodes (one past the last dof) and pass it to FixedProjectiveConstraint::addConstraint. Stop the loop before the index leaves the valid dof range.
fredroy
added
pr: fix
pr: clean
pr: status to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
(Claude)
prev_xIdsearch could end== m_nodeCurvAbs.size(), then indexedm_nodeCurvAbs[prev_xId]/m_idInstrumentCurvAbsTable[prev_xId]out of bounds. Clamp to the last node.deploy_*controlledInstrumentpassed the upper-bound-only checks inonBeginAnimationStep()andapplyAction()and was used as a negative index. Rejectid < 0.,deploy_negativeControlledInstrument_fallsBackToZero`computeInstrumentsCurvAbs()accessedxP_noticeable_I[size()-1]unconditionally; an empty sampling vector underflows. Skip such an instrument.interventionalRadiologyCollisionControls()used0as the "nothing to remove" sentinel insegRemove, dropping a collision point at index0. Use-1.totalLengthIsChanging()monotonic clamp started ati > 1, skipping node 1, which could dip below the origin and feed unsorted abscissa into the STEP 3 interpolation. Start ati > 0.deploy_*firstSimulatedNode + i == numberOfNodes(one past the last dof) and pass it toaddConstraint. Bound the loop.