Skip to content

Delegate unmatched application requests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuel-williams-shopify merged 1 commit into from
Sep 4, 2026
Merged

Delegate unmatched application requests #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions context/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,6 @@ class Application < Lively::Application
end
end

# Unmatched routes are passed here:
def handle(request)
delegate.call(request)
end

private

def render(body)
Expand All @@ -144,6 +139,8 @@ end

Routes match exact paths and may accept one or more HTTP methods. Query parameters are decoded using `protocol-url` and passed to the handler as its second argument. Routes without an explicit method accept every method.

Requests which do not match a route are passed to the application's delegate. An application using client-side history routing can instead override `#handle` to return its index page for unmatched paths.

## Live Reloading

To enable live reloading, add the `io-watch` gem to your `gems.rb` file:
Expand Down
7 changes: 2 additions & 5 deletions guides/getting-started/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,6 @@ class Application < Lively::Application
end
end

# Unmatched routes are passed here:
def handle(request)
delegate.call(request)
end

private

def render(body)
Expand All @@ -144,6 +139,8 @@ end

Routes match exact paths and may accept one or more HTTP methods. Query parameters are decoded using `protocol-url` and passed to the handler as its second argument. Routes without an explicit method accept every method.

Requests which do not match a route are passed to the application's delegate. An application using client-side history routing can instead override `#handle` to return its index page for unmatched paths.

## Live Reloading

To enable live reloading, add the `io-watch` gem to your `gems.rb` file:
Expand Down
8 changes: 6 additions & 2 deletions lib/lively/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,19 @@ def index

# Handle a standard HTTP request which did not match a configured route.
# @parameter request [Protocol::HTTP::Request] The incoming HTTP request.
# @returns [Protocol::HTTP::Response] The HTTP response with the rendered page.
# @returns [Protocol::HTTP::Response] The delegate response.
def handle(request)
return Protocol::HTTP::Response[200, [], [self.index.call]]
return delegate.call(request)
end

# Add the standard application routes to the given router.
# Override this method and call `super` to add application-specific routes.
# @parameter router [Router] The router to configure.
def configure_routes(router)
router.get("/") do
Protocol::HTTP::Response[200, [], [self.index.call]]
end

router.route("/live") do |request|
Async::WebSocket::Adapters::HTTP.open(request, &self.method(:live)) || Protocol::HTTP::Response[400]
end
Expand Down
38 changes: 16 additions & 22 deletions test/lively/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,27 +207,12 @@ def mock_page.connection; @connection; end
end

with "#handle" do
it "returns a 200 response" do
response = application.handle(Protocol::HTTP::Request.new("http", "localhost", "GET", "/"))
it "delegates unmatched requests" do
response = application.handle(Protocol::HTTP::Request.new("http", "localhost", "GET", "/unknown"))

expect(response).to be_a(Protocol::HTTP::Response)
expect(response.status).to be == 200
end

it "returns HTML content" do
response = application.handle(Protocol::HTTP::Request.new("http", "localhost", "GET", "/"))

expect(response.body).to be_a(Protocol::HTTP::Body::Buffered)
html = response.body.read
expect(html).to be_a(String)
expect(html).to be(:include?, "<!DOCTYPE html>")
end

it "includes application title in response" do
response = application.handle(Protocol::HTTP::Request.new("http", "localhost", "GET", "/"))
html = response.body.read

expect(html).to be(:include?, "Lively::Application")
expect(response.status).to be == 404
expect(response.read).to be == "Not Found"
end
end

Expand All @@ -236,6 +221,15 @@ def mock_page.connection; @connection; end
expect(application.router).to be_equal(application.router)
end

it "routes the application index explicitly" do
response = application.router.call(Protocol::HTTP::Request.new("http", "localhost", "GET", "/"))
html = response.read

expect(response.status).to be == 200
expect(html).to be(:include?, "<!DOCTYPE html>")
expect(html).to be(:include?, "Lively::Application")
end

it "can be extended by subclasses" do
application_class = Class.new(Lively::Application) do
def configure_routes(router)
Expand Down Expand Up @@ -320,11 +314,11 @@ def configure_routes(router)
expect(response.read).to be(:include?, "Hello, I'm Lively!")
end

it "handles different paths correctly" do
it "delegates unmatched paths" do
response = client.get("/some/other/path")

expect(response.status).to be == 200
expect(response.read).to be(:include?, "Hello, I'm Lively!")
expect(response.status).to be == 404
expect(response.read).to be == "Not Found"
end
end
end
Loading