Skip to content

Delegate unmatched application requests - #8

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
delegate-unmatched-requests
Sep 4, 2026
Merged

Delegate unmatched application requests#8
samuel-williams-shopify merged 1 commit into
mainfrom
delegate-unmatched-requests

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

  • register the default application index as an explicit GET / route
  • pass unmatched requests to the middleware delegate
  • document how applications can opt into SPA-style history fallback

This makes Lively::Application compose normally with other HTTP middleware. Previously, every unmatched path rendered the application index and the configured delegate was never consulted.

Compatibility

Applications relying on unknown paths rendering the index can preserve that behavior by overriding #handle.

Verification

  • bundle exec sus
  • bundle exec rubocop

Assisted-By: devx/eb377015-8099-4dd4-ae2e-835d6d6a6387
@samuel-williams-shopify
samuel-williams-shopify merged commit 638f622 into main Sep 4, 2026
22 of 28 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the delegate-unmatched-requests branch September 4, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant