Skip to content

fix(tailscale): omit a cleared auth key expiry, fix flow logs typo, and include the oldest uncovered IndexNow run - #9397

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/v0934-review-followups
Oct 27, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/v0934-review-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Tailscale Create Auth Key: a cleared Expiry field no longer forwards expirySeconds: ""; it is omitted so Tailscale's default applies
  • Tailscale tailnet settings: fix "network flog logs" typo in both tools (and the generated docs/tool outputs)
  • IndexNow: when no earlier run succeeded, diff from the oldest uncovered run's first parent so that run's own changed URLs are submitted too

Type of Change

  • Bug fix

Testing

  • biome on the changed TS files; actionlint on the workflow (no new findings)
  • Generated docs/tool-outputs updated with the same one-word change the generators produce

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…nd include the oldest uncovered IndexNow run
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 27, 2026 7:31am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the earlier IndexNow fallback issue is fixed.

Summary

Fixes Tailscale auth-key expiry handling, corrects “network flow logs” descriptions, and includes the oldest uncovered run’s changes in IndexNow submissions.

  • A cleared Tailscale auth-key expiry lets Tailscale use its default.
  • IndexNow includes changes from the oldest run when no earlier run succeeded.
  • Tailscale settings call network flow logs by the right name.

Reviews (2) · Last reviewed commit: "fix(ci): fail the IndexNow step when the..." · Reviewed by Greptile

Comment thread .github/workflows/ci.yml Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/ci.yml
@waleedlatif1
waleedlatif1 merged commit 8911b77 into staging Oct 27, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant