Skip to content

Commit 8911b77

Browse files
authored
fix(tailscale): omit a cleared auth key expiry, fix flow logs typo, and include the oldest uncovered IndexNow run (#9397)
* fix(tailscale): omit a cleared auth key expiry, fix flow logs typo, and include the oldest uncovered IndexNow run * chore(ci): reflow the IndexNow base comment * fix(ci): fail the IndexNow step when the oldest run's parent cannot be resolved
1 parent 4af6c5e commit 8911b77

6 files changed

Lines changed: 15 additions & 10 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -671,10 +671,11 @@ jobs:
671671
# push: a push that never deployed, or whose submission failed, would otherwise drop its
672672
# changed URLs for good. The check-runs lookup asks for this one check per commit, so it
673673
# stays small and counts every attempt of a re-run; a lookup that errors counts as no
674-
# success. With no success in view, the base is the oldest run in view, so URLs that no
675-
# submission ever covered are sent now. The diff needs only the two trees, so that one
676-
# commit is fetched alone; an all-zero `before` (the branch's first push) has no base,
677-
# which the script skips.
674+
# success. With no success in view, the base is the first parent of the oldest run in view,
675+
# so URLs that no submission ever covered, that run's own included, are sent now; a failed
676+
# parent lookup fails the step, so the next run retries from the same base. The diff
677+
# needs only the two trees, so that one commit is fetched alone; an all-zero `before` (the
678+
# branch's first push) has no base, which the script skips.
678679
- name: Submit changed URLs to IndexNow
679680
env:
680681
GH_TOKEN: ${{ github.token }}
@@ -691,7 +692,10 @@ jobs:
691692
fi
692693
done < <(gh api "repos/$GITHUB_REPOSITORY/actions/workflows/ci.yml/runs?branch=main&event=push&per_page=30" \
693694
--jq ".workflow_runs[] | select(.id < $GITHUB_RUN_ID) | .head_sha")
694-
BASE_SHA="${BASE_SHA:-${OLDEST_SHA:-$PUSH_BEFORE}}"
695+
if [[ -z "$BASE_SHA" && -n "$OLDEST_SHA" ]]; then
696+
BASE_SHA="$(gh api "repos/$GITHUB_REPOSITORY/commits/$OLDEST_SHA" --jq '.parents[0].sha // empty')"
697+
fi
698+
BASE_SHA="${BASE_SHA:-$PUSH_BEFORE}"
695699
echo "Submitting URLs changed in $BASE_SHA..$GITHUB_SHA"
696700
if [[ ! "$BASE_SHA" =~ ^0+$ ]]; then
697701
git fetch --no-tags --depth=1 origin "$BASE_SHA"

‎apps/docs/content/docs/integrations/tailscale.mdx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,7 @@ Get tailnet settings
11381138
| ↳ `devicesKeyDurationDays` | number | The \[key expiry\]\(/docs/features/access-control/key-expiry\) duration for devices on this tailnet |
11391139
| ↳ `usersApprovalOn` | boolean | Whether \[user approval\]\(/docs/features/access-control/user-approval\) is enabled for this tailnet |
11401140
| ↳ `usersRoleAllowedToJoinExternalTailnets` | string | Which user roles are allowed to \[join external tailnets\]\(/docs/features/sharing/how-to/invite-any-user\) |
1141-
| ↳ `networkFlowLoggingOn` | boolean | Whether \[network flog logs\]\(/docs/features/logging/network-flow-logs\) are enabled for the tailnet |
1141+
| ↳ `networkFlowLoggingOn` | boolean | Whether \[network flow logs\]\(/docs/features/logging/network-flow-logs\) are enabled for the tailnet |
11421142
| ↳ `regionalRoutingOn` | boolean | Whether \[regional routing\]\(/docs/features/route-selection#regional-routing\) is enabled for the tailnet |
11431143
| ↳ `routeSelection` | string | The \[route selection\]\(/docs/features/route-selection\) algorithm used by the tailnet: * `active-passive-failover` - Active-passive failover \(formerly known as "Failover"\) * `regional-routing` - Regional routing * `regional-routing-failover` - Regional routing with in-region failover * `magicroute` - MagicRoute A PATCH request must not specify both the `regionalRoutingOn` and `routeSelection` fields |
11441144
| ↳ `postureIdentityCollectionOn` | boolean | Whether \[identity collection\]\(/docs/features/access-control/device-management/how-to/manage-identity\) is enabled for \[device posture\]\(/docs/features/device-posture\) integrations for the tailnet |
@@ -1173,7 +1173,7 @@ Update selected tailnet settings
11731173
| ↳ `devicesKeyDurationDays` | number | The \[key expiry\]\(/docs/features/access-control/key-expiry\) duration for devices on this tailnet |
11741174
| ↳ `usersApprovalOn` | boolean | Whether \[user approval\]\(/docs/features/access-control/user-approval\) is enabled for this tailnet |
11751175
| ↳ `usersRoleAllowedToJoinExternalTailnets` | string | Which user roles are allowed to \[join external tailnets\]\(/docs/features/sharing/how-to/invite-any-user\) |
1176-
| ↳ `networkFlowLoggingOn` | boolean | Whether \[network flog logs\]\(/docs/features/logging/network-flow-logs\) are enabled for the tailnet |
1176+
| ↳ `networkFlowLoggingOn` | boolean | Whether \[network flow logs\]\(/docs/features/logging/network-flow-logs\) are enabled for the tailnet |
11771177
| ↳ `regionalRoutingOn` | boolean | Whether \[regional routing\]\(/docs/features/route-selection#regional-routing\) is enabled for the tailnet |
11781178
| ↳ `routeSelection` | string | The \[route selection\]\(/docs/features/route-selection\) algorithm used by the tailnet: * `active-passive-failover` - Active-passive failover \(formerly known as "Failover"\) * `regional-routing` - Regional routing * `regional-routing-failover` - Regional routing with in-region failover * `magicroute` - MagicRoute A PATCH request must not specify both the `regionalRoutingOn` and `routeSelection` fields |
11791179
| ↳ `postureIdentityCollectionOn` | boolean | Whether \[identity collection\]\(/docs/features/access-control/device-management/how-to/manage-identity\) is enabled for \[device posture\]\(/docs/features/device-posture\) integrations for the tailnet |

‎apps/sim/blocks/blocks/tailscale.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,7 @@ export const TailscaleBlock: BlockConfig = {
752752
...params,
753753
dns: params.dnsServers,
754754
description: params.authKeyDescription,
755+
expirySeconds: undefined,
755756
name: params.name ?? '',
756757
role: params.operation === 'list_users' ? params.roleFilter || undefined : params.role,
757758
}

‎apps/sim/tools/generated/tool-outputs.ts‎

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

‎apps/sim/tools/tailscale/get_tailnet_settings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export const tailscaleGetTailnetSettingsTool: ToolConfig<
117117
networkFlowLoggingOn: {
118118
type: 'boolean',
119119
description:
120-
'Whether [network flog logs](/docs/features/logging/network-flow-logs) are enabled for the tailnet',
120+
'Whether [network flow logs](/docs/features/logging/network-flow-logs) are enabled for the tailnet',
121121
nullable: true,
122122
},
123123
regionalRoutingOn: {

‎apps/sim/tools/tailscale/update_tailnet_settings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export const tailscaleUpdateTailnetSettingsTool: ToolConfig<
134134
networkFlowLoggingOn: {
135135
type: 'boolean',
136136
description:
137-
'Whether [network flog logs](/docs/features/logging/network-flow-logs) are enabled for the tailnet',
137+
'Whether [network flow logs](/docs/features/logging/network-flow-logs) are enabled for the tailnet',
138138
nullable: true,
139139
},
140140
regionalRoutingOn: {

0 commit comments

Comments
 (0)