Skip to content

TT-7581 Improve the spreadsheet by keeping the table header fixed (sticky) while scrolling #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtryus merged 2 commits into from
Sep 10, 2026
Merged

TT-7581 Improve the spreadsheet by keeping the table header fixed (sticky) while scrolling #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
817dc61
TT-7581 Remove padding around the datasheet
jeehoh Sep 4, 2026
fbdc06f
TT-7581 Make the header row sticky
jeehoh Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/renderer/src/components/Sheet/PlanSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ const SheetRow = ({
);
};

const ContentDiv = styled('div')(({ theme }) => ({
const headerRule = '#DDD';

export const ContentDiv = styled('div')(({ theme }) => ({
// Growing topPad must not scroll-anchor into a curTop feedback loop.
overflowAnchor: 'none',
Comment thread
jeehoh marked this conversation as resolved.
'& .data-grid-container .data-grid .cell': {
Expand All @@ -125,6 +127,15 @@ const ContentDiv = styled('div')(({ theme }) => ({
paddingLeft: theme.spacing(0.5),
paddingRight: theme.spacing(0.5),
},
'& .data-grid-container .data-grid tr:first-of-type .cell': {
position: 'sticky',
top: 0,
zIndex: 2,
Comment thread
jeehoh marked this conversation as resolved.
boxShadow: `inset 0 1px 0 ${headerRule}, inset 0 -1px 0 ${headerRule}`,
},
'& .data-grid-container .data-grid tr:first-of-type .cell.selected': {
boxShadow: `inset 0 1px 0 ${headerRule}, inset 0 -1px 0 ${headerRule}, inset 0 -100px 0 rgba(33, 133, 208, 0.15)`,
},
'& .data-grid-container .data-grid .cell.set': {
backgroundColor: theme.palette.background.default,
},
Expand Down Expand Up @@ -605,6 +616,14 @@ export function PlanSheet(props: IProps) {
return edge;
};

/** Height of the sticky header row, which overlays the top of the scroller. */
const headerHeight = () => {
const table = sheetRef.current?.querySelector(
'table.data-grid'
) as HTMLTableElement | null;
return (table?.rows?.[0] as HTMLElement | undefined)?.offsetHeight ?? 0;
};

/** Scroll the scroller only if the row is clipped. `force` after a remount. */
const alignRowInScroller = (
scroller: HTMLElement,
Expand All @@ -613,8 +632,10 @@ export function PlanSheet(props: IProps) {
) => {
const er = el.getBoundingClientRect();
const sr = scroller.getBoundingClientRect();
if (force === 'start' || er.top < sr.top) {
scroller.scrollTop += er.top - sr.top;
// Rows pass under the sticky header, so the usable top starts below it.
const top = sr.top + headerHeight();
if (force === 'start' || er.top < top) {
scroller.scrollTop += er.top - top;
} else if (force === 'end' || er.bottom > sr.bottom) {
scroller.scrollTop += er.bottom - sr.bottom;
}
Expand Down Expand Up @@ -1511,8 +1532,7 @@ export function PlanSheet(props: IProps) {
</Box>
</Box>
}
drawBottomBorder={true}
contentSx={(theme) => ({ p: theme.layout.gap, position: 'relative' })}
contentSx={{ position: 'relative' }}
contentRef={scrollRef}
>
<Dialog open={goToOpen} onClose={() => setGoToOpen(false)} maxWidth="sm">
Expand Down
Loading