TT-7581 Improve the spreadsheet by keeping the table header fixed (sticky) while scrolling - #582
Draft
nghtctrl wants to merge 2 commits into
Draft
TT-7581 Improve the spreadsheet by keeping the table header fixed (sticky) while scrolling#582nghtctrl wants to merge 2 commits into
nghtctrl wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new sticky-header styling currently relies on hard-coded colors and lacks an explicit theme-aware background for the sticky cells, which can reduce readability (especially in dark mode) and allow content to show through.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves the Sections & Passages planning datasheet UX by keeping column headers visible while scrolling, and by tightening the sheet layout to reduce surrounding whitespace.
Changes:
- Made the header row sticky via
ContentDivstyles. - Updated row-alignment scrolling logic to account for the sticky header overlay height.
- Removed extra content padding around the datasheet area.
File summaries
| File | Description |
|---|---|
| src/renderer/src/components/Sheet/PlanSheet.tsx | Adds sticky header styling + scroll alignment updates; adjusts layout spacing around the sheet. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+119
to
123
| const headerRule = '#DDD'; | ||
|
|
||
| export const ContentDiv = styled('div')(({ theme }) => ({ | ||
| // Growing topPad must not scroll-anchor into a curTop feedback loop. | ||
| overflowAnchor: 'none', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: