Repository navigation
[#62] Update octocrab to 0.19 - #63
Merged
Merged
Conversation
heitor-lassarote
marked this pull request as ready for review
September 25, 2026 22:29
heitor-lassarote
force-pushed
the
heitor-lassarote/#62-octocrab-0.19
branch
from
September 28, 2026 14:47
9fdab12 to
68da6e2
Compare
heitor-lassarote
force-pushed
the
heitor-lassarote/#62-octocrab-0.19
branch
from
September 28, 2026 18:06
68da6e2 to
75a424f
Compare
Martoon-00
approved these changes
Oct 9, 2026
heitor-lassarote
force-pushed
the
heitor-lassarote/#62-octocrab-0.19
branch
2 times, most recently
from
October 14, 2026 13:39
ead65c2 to
a4ac4da
Compare
heitor-lassarote
force-pushed
the
heitor-lassarote/#62-octocrab-0.19
branch
from
October 14, 2026 13:48
a4ac4da to
8dfdef2
Compare
Problem: `octocrab` 0.18.1 depends on `hyperx` 1.4.0, which requires `bytes` below 1.2. Without the committed Cargo.lock, `combine` 4.6.8 is picked through `gitlab`, and it needs a newer `bytes`, so the build fails. `cargo install update-daemon` without `--locked` resolves dependencies this way. Solution: update `octocrab` to 0.19, which no longer depends on `hyperx`. No code changes are needed. In the lockfile, `hyperx`, `base64` 0.20, `language-tags` and `unicase` go away, and `tracing-attributes` is added.
heitor-lassarote
force-pushed
the
heitor-lassarote/#62-octocrab-0.19
branch
from
October 14, 2026 13:49
8dfdef2 to
f7884ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
octocrabfrom 0.18.1 to 0.19. 0.18.1 depends onhyperx, which capsbytesbelow 1.2, and without the committedCargo.lockthat makescombinefail to build.cargo install update-daemonwithout--lockedwould hit this once the crate is published. 0.19 no longer depends onhyperx, and no code changes are needed.This is stacked on #61 (and so on #59). Once those are merged, this PR's base becomes
master.Related issue(s)
Resolves #62
Notes for reviewers
Cargo.lockremoved, a fresh resolution picksbytes1.12.1, contains nohyperx, and builds. With the resolver change from [#56] Move to upstream ssh2-config 0.8 #59 it also stays on versions compatible with Rust 1.88.nix build, which runs the tests and pedantic clippy, passes.GITHUB_TOKEN, each call is now sent 3 times before it fails with the same error.