Repository navigation
[#65] Fix clippy lints from a fresh dependency resolution - #66
Merged
heitor-lassarote merged 1 commit intoOct 14, 2026
Merged
Conversation
heitor-lassarote
marked this pull request as ready for review
September 28, 2026 16:50
heitor-lassarote
force-pushed
the
heitor-lassarote/#65-fresh-resolution-clippy
branch
from
September 28, 2026 18:08
677a858 to
8745e00
Compare
Martoon-00
reviewed
Oct 9, 2026
Martoon-00
approved these changes
Oct 9, 2026
heitor-lassarote
force-pushed
the
heitor-lassarote/#65-fresh-resolution-clippy
branch
from
October 9, 2026 16:38
8745e00 to
2ed9883
Compare
heitor-lassarote
force-pushed
the
heitor-lassarote/#65-fresh-resolution-clippy
branch
3 times, most recently
from
October 14, 2026 13:49
963cad7 to
0912309
Compare
Problem: without the committed Cargo.lock, dependencies resolve to log 0.4.34 and chrono 0.4.45, instead of the locked 0.4.21 and 0.4.34. Against those, pedantic clippy reports 20 errors that do not fire against the committed lockfile: `uninlined_format_args`, `unnecessary_debug_formatting` and `to_string_in_format_args` in existing debug!/info!/warn!/error! calls, and one use of `chrono::NaiveDateTime::from_timestamp_opt`, deprecated in chrono 0.4.39. Solution: fix them without changing behaviour. `from_timestamp_opt` becomes `chrono::DateTime::from_timestamp(..).unwrap().naive_utc()`, its documented replacement. The rest are inlined format arguments and a redundant `.to_string()`. Verified clippy passes both with the committed lockfile and with a freshly generated one.
heitor-lassarote
force-pushed
the
heitor-lassarote/#65-fresh-resolution-clippy
branch
from
October 14, 2026 13:50
0912309 to
5ac1e4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without the committed
Cargo.lock, dependencies resolve tolog0.4.34 andchrono0.4.45. Against those, pedantic clippy reports 20 errors that don't fire against the committed lockfile: inlined-format-args andunnecessary_debug_formatting/to_string_in_format_argslints againstlog's macros, and onechrono::NaiveDateTime::from_timestamp_optdeprecation.cargo clippyruns innix build(doCheck, turned on in #59), so acargo updatethat picks up newerlog/chronowould break CI. This makes it pass either way, with no behaviour change.This is stacked on #63 (and so on #61 and #59). Once those are merged, this PR's base becomes
master.Related issue(s)
Resolves #65
Notes for reviewers
Cargo.lockand a freshly generated one;Cargo.lockitself is untouched.nix build, which runs the tests and pedantic clippy, passes.