Skip to content

release: 0.43.1 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbianst merged 1 commit into from
Oct 30, 2026
Merged

release: 0.43.1 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "0.43.0"
".": "0.43.1"
}
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [0.43.1](https://github.com/sentdm/sent-dm-php/compare/v0.43.0...v0.43.1) (2026-10-30)


### Documentation

* **api:** describe the default body type on template bodies ([6a67292](https://github.com/sentdm/sent-dm-php/commit/6a67292922af2f9505933ab924357796149e531c))

## [0.43.0](https://github.com/sentdm/sent-dm-php/compare/v0.42.0...v0.43.0) (2026-10-30)


Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The REST API documentation can be found on [docs.sent.dm](https://docs.sent.dm).
<!-- x-release-please-start-version -->

```
composer require "sentdm/sent-dm-php 0.43.0"
composer require "sentdm/sent-dm-php 0.43.1"
```

<!-- x-release-please-end -->
Expand Down
2 changes: 1 addition & 1 deletion src/Version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
namespace SentDm;

// x-release-please-start-version
const VERSION = '0.43.0';
const VERSION = '0.43.1';

@claude claude Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) Customers installing 0.43.1 will send X-Stainless-Package-Version: 0.43.0 on every request, while User-Agent says 0.43.1. The release bumps VERSION here, but src/Client.php:120 hard-codes '0.43.0'. That file is not in release-please's extra-files, so the tagged code ships with the old version. Fix: in the SDK configuration, have the generator build that header from VERSION, as User-Agent already does. Or emit x-release-please markers there and list src/Client.php in extra-files in a generated commit. Every release PR then bumps every version string. Don't hand-edit either file.

Why this was flagged

src/Client.php:118 builds User-Agent from the VERSION constant, which this PR sets to '0.43.1' at src/Version.php:8. src/Client.php:120 sets 'X-Stainless-Package-Version' => '0.43.0' as a literal. release-please-config.json extra-files lists only README.md and src/Version.php, so this release PR leaves the literal alone. Once the PR merges, the published v0.43.1 package sends conflicting version headers on every request, and server-side analytics or debugging that keys on the package-version header files 0.43.1 traffic under 0.43.0. The literal is only fixed after the release, by a later ci(sdk): sync generated files after the release commit (b8d2bae changed '0.42.0' to '0.43.0' after 0.43.0 shipped). That sync never reaches the tagged code, so each release ships the previous version, as 0.43.0 did. The PR task asks that version strings match everywhere, and this one does not.

Verification: nit. Trigger: every request from the published v0.43.1 package. This PR sets VERSION to '0.43.1' at src/Version.php:8, but src/Client.php:120 is the literal 'X-Stainless-Package-Version' => '0.43.0',. Client.php has no markers, so release-please does not rewrite the literal. On the base commit both values are 0.43.0 and agree.

// x-release-please-end
Loading