Repository navigation
release: 0.43.1 - #64
Conversation
|
|
||
| // x-release-please-start-version | ||
| const VERSION = '0.43.0'; | ||
| const VERSION = '0.43.1'; |
There was a problem hiding this comment.
🟡 (optional) Customers installing 0.43.1 will send X-Stainless-Package-Version: 0.43.0 on every request, while User-Agent says 0.43.1. The release bumps VERSION here, but src/Client.php:120 hard-codes '0.43.0'. That file is not in release-please's extra-files, so the tagged code ships with the old version. Fix: in the SDK configuration, have the generator build that header from VERSION, as User-Agent already does. Or emit x-release-please markers there and list src/Client.php in extra-files in a generated commit. Every release PR then bumps every version string. Don't hand-edit either file.
Why this was flagged
src/Client.php:118 builds User-Agent from the VERSION constant, which this PR sets to '0.43.1' at src/Version.php:8. src/Client.php:120 sets 'X-Stainless-Package-Version' => '0.43.0' as a literal. release-please-config.json extra-files lists only README.md and src/Version.php, so this release PR leaves the literal alone. Once the PR merges, the published v0.43.1 package sends conflicting version headers on every request, and server-side analytics or debugging that keys on the package-version header files 0.43.1 traffic under 0.43.0. The literal is only fixed after the release, by a later ci(sdk): sync generated files after the release commit (b8d2bae changed '0.42.0' to '0.43.0' after 0.43.0 shipped). That sync never reaches the tagged code, so each release ships the previous version, as 0.43.0 did. The PR task asks that version strings match everywhere, and this one does not.
Verification: nit. Trigger: every request from the published v0.43.1 package. This PR sets VERSION to '0.43.1' at src/Version.php:8, but src/Client.php:120 is the literal 'X-Stainless-Package-Version' => '0.43.0',. Client.php has no markers, so release-please does not rewrite the literal. On the base commit both values are 0.43.0 and agree.
|
🤖 Created releases: 🌻 |
Automated Release PR
0.43.1 (2026-10-30)
Documentation
This PR was generated with Release Please. See documentation.