Remove unused arguments of functions - #162641
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? me r=me once CI is green @bors rollup |
Member
Author
|
@bors r=boxyuwu |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
We do plan to land a way for code to opt out of dead code analysis, see #160621 |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 11, 2026
…yuwu Remove unused arguments of functions That these arguments are unused was hidden by the `#[trace::instrument]` macro, which uses the arguments. I don't see an easy way to avoid this from happening in the future.
rust-bors
Bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
unused_args
branch
from
September 12, 2026 07:27
15fd45c to
80e7183
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=BoxyUwU |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 12, 2026
…yUwU Remove unused arguments of functions That these arguments are unused was hidden by the `#[trace::instrument]` macro, which uses the arguments. I don't see an easy way to avoid this from happening in the future.
Member
|
I ran into some of these recently, and I wonder if e.g. the name parameter was kept there precisely to be seen in tracing logs? |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 12, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162623 (Use GrowableBitSet in the main loop of `rustc_mir_transform::sroa`) - #162678 (Disconnect `rustc_codegen_ssa` from `rustc_mir_transform`) - #162641 (Remove unused arguments of functions) - #162663 (Rustdoc issue template: fix typo in comment ("thorugh")) - #162684 (Add `E0747` explanation for `type/const` mismatch case) - #162685 (Stabilize `Vec::from_fn`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 12, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162623 (Use GrowableBitSet in the main loop of `rustc_mir_transform::sroa`) - #162678 (Disconnect `rustc_codegen_ssa` from `rustc_mir_transform`) - #162641 (Remove unused arguments of functions) - #162663 (Rustdoc issue template: fix typo in comment ("thorugh")) - #162684 (Add `E0747` explanation for `type/const` mismatch case) - #162685 (Stabilize `Vec::from_fn`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 12, 2026
Rollup merge of #162641 - JonathanBrouwer:unused_args, r=BoxyUwU Remove unused arguments of functions That these arguments are unused was hidden by the `#[trace::instrument]` macro, which uses the arguments. I don't see an easy way to avoid this from happening in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That these arguments are unused was hidden by the
#[trace::instrument]macro, which uses the arguments.I don't see an easy way to avoid this from happening in the future.