[rustdoc] Change table odd table rows background color to not make it the same as inline code - #160438
Open
GuillaumeGomez wants to merge 2 commits into
Open
[rustdoc] Change table odd table rows background color to not make it the same as inline code#160438GuillaumeGomez wants to merge 2 commits into
GuillaumeGomez wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-js
GuillaumeGomez
changed the title
Contributor
|
i feel like the odd/even colors should be swapped so they dont get doubled up if theres a header. and maybe too much of a nitpick but i feel like tables with a small number of rows (~2 or 3) dont need the alternating color. |
Member
Author
Fair enough!
I'd prefer to keep it coherent whatever the number of rows. Simpler for maintenance and no surprise to users. |
GuillaumeGomez
force-pushed
the
table-odd-code
branch
from
August 12, 2026 21:09
5026db0 to
e7e5245
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
I switched the odd/even background for table rows. Now looks like this: 
|
notriddle
approved these changes
Aug 12, 2026
Member
Author
|
@bors r=notriddle,lolbinarycat |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 12, 2026
…otriddle,lolbinarycat [rustdoc] Change table odd table rows background color to not make it the same as inline code Fixes rust-lang#159234. Follow-up of rust-lang#105442. It now looks like this: <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-15" src="https://github.com/user-attachments/assets/97d2ae1c-e167-4cc0-8daf-d8937397faed" /> <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-21" src="https://github.com/user-attachments/assets/8916a49d-2496-4045-820a-12f10f18d81b" /> <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-25" src="https://github.com/user-attachments/assets/b44b3b3f-8ec7-4fea-b783-aedf1b452249" /> For the light theme, I had to make the inline code background darker so it would mix well with the alternative table rows background color. r? @notriddle
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 13, 2026
…otriddle,lolbinarycat [rustdoc] Change table odd table rows background color to not make it the same as inline code Fixes rust-lang#159234. Follow-up of rust-lang#105442. It now looks like this: <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-15" src="https://github.com/user-attachments/assets/97d2ae1c-e167-4cc0-8daf-d8937397faed" /> <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-21" src="https://github.com/user-attachments/assets/8916a49d-2496-4045-820a-12f10f18d81b" /> <img width="418" height="163" alt="Screenshot From 2026-08-03 15-21-25" src="https://github.com/user-attachments/assets/b44b3b3f-8ec7-4fea-b783-aedf1b452249" /> For the light theme, I had to make the inline code background darker so it would mix well with the alternative table rows background color. r? @notriddle
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 13, 2026
Rollup of 13 pull requests Successful merges: - #160976 (Ensure TLS accesses don't call the global allocator through panic (part 2)) - #160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code) - #160985 (self-profile more of borrowck) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #159566 (Add support for generics in `offload`and remove `no_mangle` attribute) - #160676 (rustc_public: split `def`s out of `ty`) - #160861 (rustc_parse: suggest removing semicolon before `if` block) - #160958 (Remove unused `#[non_exhaustive]` in library) - #160978 (move resolve_path to Session inherent method) - #160990 (Remove old cfg parser which is now dead code) - #160991 (Add offload component on nightly) - #160999 (doc changes to expect messages in process.rs) - #161003 (Also warn if an invalid `doc` attribute is used on a macro invocation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159234.
Follow-up of #105442.
It now looks like this:
For the light theme, I had to make the inline code background darker so it would mix well with the alternative table rows background color.
r? @notriddle