Rollup of 13 pull requests by jhpratt · Pull Request #161014 · rust-lang/rust

jhpratt · 2026-08-13T00:17:38Z

Successful merges:

Ensure TLS accesses don't call the global allocator through panic (part 2) #160976 (Ensure TLS accesses don't call the global allocator through panic (part 2))
[rustdoc] Change table odd table rows background color to not make it the same as inline code #160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code)
self-profile more of borrowck #160985 (self-profile more of borrowck)
Add new unused_footnote_definition rustdoc lint #137858 (Add new unused_footnote_definition rustdoc lint)
Add support for generics in offloadand remove no_mangle attribute #159566 (Add support for generics in offloadand remove no_mangle attribute)
rustc_public: split defs out of ty #160676 (rustc_public: split defs out of ty)
rustc_parse: suggest removing semicolon before if block #160861 (rustc_parse: suggest removing semicolon before if block)
Remove unused #[non_exhaustive] in library #160958 (Remove unused #[non_exhaustive] in library)
move resolve_path to Session inherent method #160978 (move resolve_path to Session inherent method)
Remove old cfg parser which is now dead code #160990 (Remove old cfg parser which is now dead code)
Add offload component on nightly #160991 (Add offload component on nightly)
doc changes to expect messages in process.rs #160999 (doc changes to expect messages in process.rs)
Also warn if an invalid doc attribute is used on a macro invocation #161003 (Also warn if an invalid doc attribute is used on a macro invocation)

This is torture.

…as inline code

Rollup of 13 pull requests Successful merges: - #160976 (Ensure TLS accesses don't call the global allocator through panic (part 2)) - #160438 ([rustdoc] Change table odd table rows background color to not make it the same as inline code) - #160985 (self-profile more of borrowck) - #137858 (Add new `unused_footnote_definition` rustdoc lint) - #159566 (Add support for generics in `offload`and remove `no_mangle` attribute) - #160676 (rustc_public: split `def`s out of `ty`) - #160861 (rustc_parse: suggest removing semicolon before `if` block) - #160958 (Remove unused `#[non_exhaustive]` in library) - #160978 (move resolve_path to Session inherent method) - #160990 (Remove old cfg parser which is now dead code) - #160991 (Add offload component on nightly) - #160999 (doc changes to expect messages in process.rs) - #161003 (Also warn if an invalid `doc` attribute is used on a macro invocation)

rust-log-analyzer · 2026-08-13T04:08:43Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-08-13T04:13:45Z

💔 Test for d479045 failed: CI. Failed job:

auto - dist-x86_64-msvc (web logs, enhanced plaintext logs)

jhpratt · 2026-08-13T04:25:24Z

@bors retry

@bors try jobs=dist-x86_64-msvc

Rollup of 13 pull requests try-job: dist-x86_64-msvc

rust-bors · 2026-08-13T07:26:05Z

☀️ Try build successful (CI)
Build commit: 31172ef (31172efb37c85c1e9b4160770995bb7ec57c7fdf)
Base parent: 52d0866 (52d08664805c8deb47b7e86999d7f8647b424a15)

rust-bors · 2026-08-13T10:24:10Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 2h 59m 12s
Pushing 1e5ee35 to main...

github-actions · 2026-08-13T10:27:34Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 79ef636 (parent) -> 1e5ee35 (this PR)

Test differences

Show 93 test diffs

Stage 1

[run-make] tests/run-make/offload-generic-manifest: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J1)
[ui] tests/rustdoc-ui/lints/broken-footnote.rs: [missing] -> pass (J1)
[ui] tests/rustdoc-ui/lints/unused-footnote.rs: [missing] -> pass (J1)
[ui] tests/ui/offload/check_config.rs#fail: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J2)
[ui] tests/ui/offload/check_config.rs#pass: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J2)
[ui] tests/ui/offload/duplicate_kernel.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J2)
[ui] tests/ui/offload/generic_kernel_not_instantiated.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J2)
[ui] tests/ui/parser/if-semi-before-block.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/offload/check_config.rs#fail: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J5)
[ui (polonius)] tests/ui/offload/check_config.rs#pass: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J5)
[ui (polonius)] tests/ui/offload/duplicate_kernel.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J5)
[ui (polonius)] tests/ui/offload/generic_kernel_not_instantiated.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J5)
[ui (polonius)] tests/ui/parser/if-semi-before-block.rs: [missing] -> pass (J5)

Stage 2

[ui] tests/rustdoc-ui/lints/broken-footnote.rs: [missing] -> pass (J0)
[ui] tests/rustdoc-ui/lints/unused-footnote.rs: [missing] -> pass (J0)
[run-make] tests/run-make/offload-generic-manifest: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J3)
[ui] tests/ui/offload/check_config.rs#fail: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[ui] tests/ui/offload/check_config.rs#pass: ignore (ignored when LLVM Enzyme is disabled or LLVM is not the default codegen backend) -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[ui] tests/ui/offload/duplicate_kernel.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[ui] tests/ui/offload/generic_kernel_not_instantiated.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[ui] tests/ui/parser/if-semi-before-block.rs: [missing] -> pass (J4)

Additionally, 72 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1e5ee356374211706221b71b6106d297a646ee57 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-2: 30m 15s -> 43m 40s (+44.3%)
armhf-gnu: 1h 9m -> 1h 33m (+34.4%)
x86_64-gnu-gcc-core-tests: 11m 13s -> 14m 31s (+29.4%)
x86_64-gnu-llvm-21-2: 1h 23m -> 1h (-27.7%)
dist-powerpc64-linux-musl: 1h 31m -> 1h 6m (-27.6%)
dist-x86_64-apple: 1h 59m -> 2h 29m (+25.9%)
i686-gnu-nopt-1: 2h 15m -> 1h 42m (-24.6%)
i686-gnu-nopt-2: 1h 53m -> 2h 20m (+24.3%)
dist-x86_64-illumos: 1h 50m -> 1h 24m (-24.2%)
dist-x86_64-netbsd: 1h 10m -> 1h 26m (+23.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-13T10:28:08Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#160976	Ensure TLS accesses don't call the global allocator through…	`004192fb9174ea7dfc17913e3f47f16ec482b7f9` (link)
#160438	[rustdoc] Change table odd table rows background color to n…	`3981a8f265ff0a7f99f0e521adc1cb6001130a45` (link)
#160985	self-profile more of borrowck	`9f5fce2f3385e1badd942665e8f7ba486b278727` (link)
#137858	Add new `unused_footnote_definition` rustdoc lint	`47c7eb4046ca1dba53e5987007b0e5634ea88396` (link)
#159566	Add support for generics in `offload`and remove `no_mangle`…	`6c1723e2d6ffe1926887f5f279f2fae95727437b` (link)
#160676	rustc_public: split `def`s out of `ty`	`d7677defc30b0209a8da28c9b9715119179f3ec3` (link)
#160861	rustc_parse: suggest removing semicolon before `if` block	`7f24f7fe7c2a11477f508caefa75d17237a6fbf0` (link)
#160958	Remove unused `#[non_exhaustive]` in library	`95cee242b62c28735dd3695b42c6ff7ebfe41cbe` (link)
#160978	move resolve_path to Session inherent method	`59ef68f5f380aa990328450a4fa985396dfaec70` (link)
#160990	Remove old cfg parser which is now dead code	`45f6dfae7acf1b438facd68ebbe2397569e8ed6f` (link)
#160991	Add offload component on nightly	`446f2a4dae7d8d80261f98ba2b981a75795cdaea` (link)
#160999	doc changes to expect messages in process.rs	`377cfa0b0993c8936f81701ecd961220c7c42faf` (link)
#161003	Also warn if an invalid `doc` attribute is used on a macro …	`d80b7f1be8cb521242be4672ccd20c5d22c61558` (link)

previous master: 79ef636a60

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-08-13T11:16:48Z

Finished benchmarking commit (1e5ee35): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.8%]	15
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.5%	[-8.9%, -1.5%]	4
All ❌✅ (primary)	0.3%	[0.1%, 0.8%]	15

Max RSS (memory usage)

Results (primary 7.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.1%	[7.1%, 7.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	7.1%	[7.1%, 7.1%]	1

Cycles

Results (primary -0.4%, secondary -7.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-2.1%, -1.6%]	2
Improvements ✅ (secondary)	-7.4%	[-8.0%, -6.7%]	2
All ❌✅ (primary)	-0.4%	[-2.1%, 2.5%]	3

Binary size

Results (primary 0.2%, secondary -7.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.7%]	16
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	5
Improvements ✅ (secondary)	-7.4%	[-8.8%, -6.9%]	4
All ❌✅ (primary)	0.2%	[-0.2%, 0.7%]	21

Bootstrap: 455.642s -> 457.516s (0.41%)
Artifact size: 396.40 MiB -> 396.41 MiB (0.00%)

makai410 and others added 30 commits August 7, 2026 15:29

rustc_public: split defs out of ty

83012a4

Remove unused #[non_exhaustive] in library

a184a6d

Add new rustdoc broken_footnote lint

31e436d

Add ui test for rustdoc broken_footnote lint

37b8c53

Add new unused_footnote_definition rustdoc lint

c74e84a

Add ui test for new unused_footnote_definition rustdoc lint

9f30b84

Improve description of new rustdoc lints

261a213

Remove outdated comment

4420714

Add extra "broken_footnote" lint ui test

92dcc5b

Fix backslashes and line breaks in footnote lint

7253b43

move resolve_path to Session inherent method

b9e9138

update comment

9c162cb

Split doc comment so lints are always emitted in the right order

e736996

Fix tidy error

116fdd1

self-profile more of borrowck

8447565

rustc_parse: suggest removing semicolon before if block

349eac6

Remove old cfg parser which is now dead code

2982507

Add offload component on nightly

18320e3

Add 3-pass compilation to support generics and remove no_mangle attr

4d52fe9

Remove codegen and move manifest out of query

a5a9f8c

fix

3daa8b3

ci fix

1920a16

minor fixes

30dd3d4

Add tests remove extra mode and other fixes

55c63da

Some fixes and error when missing manifest

4227e93

fix

b1b0f5e

Ensure TLS accesses don't call the global allocator through panic part 2

5b71324

This is torture.

Also warn if an invalid doc attribute is used on a macro invocation

a09d72a

Change table odd table rows background color to not make it the same …

e647d65

…as inline code

Invert table row background

e7e5245

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026

Auto merge of #161014 - jhpratt:rollup-lyWH2E3, r=<try>

31172ef

Rollup of 13 pull requests try-job: dist-x86_64-msvc

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2026

rust-bors Bot merged commit 1e5ee35 into rust-lang:main Aug 13, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Aug 13, 2026

rustbot added the perf-regression Performance regression. label Aug 13, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 13 pull requests - #161014

Rollup of 13 pull requests#161014
rust-bors[bot] merged 44 commits into
rust-lang:mainfrom
jhpratt:rollup-lyWH2E3

jhpratt commented Aug 13, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 13, 2026

Uh oh!

rust-bors Bot commented Aug 13, 2026

Uh oh!

jhpratt commented Aug 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 13, 2026

Uh oh!

rust-bors Bot commented Aug 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 13, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 13, 2026

Uh oh!

rust-timer commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 13, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 13, 2026

Uh oh!

rust-bors Bot commented Aug 13, 2026

Uh oh!

jhpratt commented Aug 13, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 13, 2026

Uh oh!

rust-bors Bot commented Aug 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 13, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 13, 2026

Uh oh!

rust-timer commented Aug 13, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants