Update to LLVM 23 - #158734
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for b003a3f failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 0259978 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 4973bfc failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Stuck in dist-x86_64-apple again, at the same file: Could it possibly be genuine? |
|
Also why does this optional autodiff job keep failing? Will every PR get those errors posted by the bot if this one lands?
|
|
I'm inclined to just let it continue, github sometimes just stops showing log output even if a job is (slowly) making progress |
|
Actually just took a look, dist-x86_64-apple just finished |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (1b29cfd): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.1%, secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.5%, secondary -2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.2%, secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 496.187s -> 457.809s (-7.73%) |
|
Wow, bootstrap down by 7.7%, among all the other improvements. |
It's intentionally not blocking yet and did it's job of giving us some heads-up, so we could develop a fix that now just needs to land: #160532 |
I get that from the name, but it'd be bad if the bot posted a message saying this job failed in every single PR, like it did here. I guess we'll see whether it does that... |
|
It does |
|
I can patch rust-log-analyzer to ignore the optional jobs. Though we will then lose our only channel that tells us that they broke 🤔 |
|
it could at least say that it's an optional job, and that those are expected to occasionally fail. Because as-is, you need to go check what went wrong (is it my fault?) and then if it's not, what do you do with this failure (it's not actionable). |

View all comments
Changes in this PR (apart from the LLVM update):
LLVM_VERSIONED_DYLIB_NAME_ON_DARWIN=OFF, which restores the previous unversioned naming of the LLVM dylib on Darwin. I expect we'll want to change this for consistency with Linux, but given the amount of trouble Darwin dylibs have caused in the past, I'm not trying to do it in this PR.i686-pc-windows-gnuhost tools compiler-team#1020.Issues: