std: move futex implementations into sys::sync::futex by valentynkit · Pull Request #158726 · rust-lang/rust

valentynkit · 2026-07-03T10:28:41Z

Moves the futex primitives out of the per-platform sys::pal modules into a single sys::sync::futex, selected with cfg_select! the same way the other sys::sync backends are.
Every consumer of these primitives already lives in sys::sync (mutex, rwlock, once, condvar, thread_parking), so they now import crate::sys::sync::futex directly instead of reaching crate::sys::futex through the pub use pal::* glob.

I placed it under sys::sync rather than a top-level sys::futex because the futex API only backs the sys::sync primitives and sits next to the existing sys::sync::thread_parking backend.

Happy to place it to sys::futex if you would rather have it as a peer of the other feature modules.

The file moves are a separate commit, recorded in .git-blame-ignore-revs so blame skips the rename.

r? joboet

rustbot · 2026-07-03T10:28:46Z

joboet is currently at their maximum review capacity.
They may take a while to respond.

Pure file moves; the module path repointing and platform gating follow in the next commit. Recorded in .git-blame-ignore-revs so blame skips the rename.

Select the platform implementation with a cfg_select! in sys::sync::futex, repoint each one at the pal primitives it uses (time, fuchsia, the windows api module, hermit_abi), and remove the now-unused futex declarations from the pal modules. The sync primitives import crate::sys::sync::futex rather than the crate::sys::futex glob re-export.

rustbot · 2026-07-29T08:44:51Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

valentynkit · 2026-07-29T08:50:35Z

Rebased onto master, and extended the move to cover the wasi futex from #159731, which landed in pal after this was opened.
r? libs

Darksonn · 2026-08-05T07:21:23Z

Sorry I'm at capacity for the next two weeks.

@rustbot reroll

jhpratt · 2026-08-05T07:28:58Z

@bors r+ rollup

rust-bors · 2026-08-05T07:29:02Z

📌 Commit 5b40f3d has been approved by jhpratt

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

std: move futex implementations into sys::sync::futex Part of rust-lang#117276. Moves the futex primitives out of the per-platform `sys::pal` modules into a single `sys::sync::futex`, selected with `cfg_select!` the same way the other `sys::sync` backends are. Every consumer of these primitives already lives in `sys::sync` (mutex, rwlock, once, condvar, thread_parking), so they now import `crate::sys::sync::futex` directly instead of reaching `crate::sys::futex` through the `pub use pal::*` glob. I placed it under `sys::sync` rather than a top-level `sys::futex` because the futex API only backs the `sys::sync` primitives and sits next to the existing `sys::sync::thread_parking` backend. Happy to place it to `sys::futex` if you would rather have it as a peer of the other feature modules. The file moves are a separate commit, recorded in `.git-blame-ignore-revs` so blame skips the rename. r? joboet

…uwer Rollup of 22 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #159784 (Hint that memchr returns an in-bounds index) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

std: move futex implementations into sys::sync::futex Part of rust-lang#117276. Moves the futex primitives out of the per-platform `sys::pal` modules into a single `sys::sync::futex`, selected with `cfg_select!` the same way the other `sys::sync` backends are. Every consumer of these primitives already lives in `sys::sync` (mutex, rwlock, once, condvar, thread_parking), so they now import `crate::sys::sync::futex` directly instead of reaching `crate::sys::futex` through the `pub use pal::*` glob. I placed it under `sys::sync` rather than a top-level `sys::futex` because the futex API only backs the `sys::sync` primitives and sits next to the existing `sys::sync::thread_parking` backend. Happy to place it to `sys::futex` if you would rather have it as a peer of the other feature modules. The file moves are a separate commit, recorded in `.git-blame-ignore-revs` so blame skips the rename. r? joboet

…uwer Rollup of 25 pull requests Successful merges: - #154585 (treat no_mangle_generic_items as hard error instead of lint warning) - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe my unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

…uwer Rollup of 25 pull requests Successful merges: - #158147 (std: fix stack buffer overflow in Windows junction_point) - #160130 (Select cache values to verify by key fingerprint, not value fingerprint) - #160343 (Rename `OutlivesPredicate` to `OutlivesClause`) - #160360 (Remove rustc_middle dependency on rustc_hir_pretty) - #160387 (rustc_codegen_ssa: Correctly apply the static `--jobs-backend` limit to backend parallelism) - #160422 (move mir-opt miri tests to CI logic) - #160444 (Avoid resolving path keywords outside `TypeNS`) - #160510 (Resolver: (un)tracked borrows for `CmRefCell` made safe by unsafe speculative flag) - #155424 ([blocked] Link to proposed LLM policy in CONTRIBUTING and pull request template) - #158726 (std: move futex implementations into sys::sync::futex) - #158762 (Emit thumb code on VEX V5) - #159225 (Split IncrCompSession out of Session) - #159820 (Make the `rustc_unsafe_specialization_marker` attribute actually `unsafe`) - #160198 (Rework `smallest_range_containing` to handle duplicates) - #160362 (Split `SpannedTypeVisitor` into its own crate, `rustc_ty_walk`) - #160390 (autodiff: Handle slice-tailed DSTs in type trees) - #160420 (Suggest `cast_signed()` for overflowing signed integer literals) - #160501 (Add bootstrap CLI snapshot test for testing miri) - #160516 (Add regression test for HRTB projection in closure) - #160520 (Add some tests for specialization) - #160522 (fix(bootstrap): Normalize the names of proc macro dependency crates) - #160523 (Add regression test for opaque type) - #160531 (docs: fix typo in AllowExprMetavar comment) - #160538 (Update expect messages in tcp.rs doc examples to follow the style guide) - #160548 (bootstrap: Register `coverage-map` and `coverage-run` aliases via a separate step)

Rollup merge of #158726 - valentynkit:sys-sync-futex, r=jhpratt std: move futex implementations into sys::sync::futex Part of #117276. Moves the futex primitives out of the per-platform `sys::pal` modules into a single `sys::sync::futex`, selected with `cfg_select!` the same way the other `sys::sync` backends are. Every consumer of these primitives already lives in `sys::sync` (mutex, rwlock, once, condvar, thread_parking), so they now import `crate::sys::sync::futex` directly instead of reaching `crate::sys::futex` through the `pub use pal::*` glob. I placed it under `sys::sync` rather than a top-level `sys::futex` because the futex API only backs the `sys::sync` primitives and sits next to the existing `sys::sync::thread_parking` backend. Happy to place it to `sys::futex` if you would rather have it as a peer of the other feature modules. The file moves are a separate commit, recorded in `.git-blame-ignore-revs` so blame skips the rename. r? joboet

rustbot assigned joboet Jul 3, 2026

valentynkit marked this pull request as ready for review July 3, 2026 15:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2026

valentynkit added 2 commits July 29, 2026 11:31

std: move futex implementations into sys::sync::futex

7232830

Pure file moves; the module path repointing and platform gating follow in the next commit. Recorded in .git-blame-ignore-revs so blame skips the rename.

valentynkit force-pushed the sys-sync-futex branch from 5191a4a to 5b40f3d Compare July 29, 2026 08:44

rustbot assigned Darksonn and unassigned joboet Jul 29, 2026

rustbot assigned jhpratt and unassigned Darksonn Aug 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2026

jhpratt mentioned this pull request Aug 5, 2026

Rollup of 16 pull requests #160549

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 22 pull requests #160554

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160557

Closed

JonathanBrouwer mentioned this pull request Aug 5, 2026

Rollup of 25 pull requests #160559

Merged

rust-bors Bot merged commit ae817ec into rust-lang:main Aug 5, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 5, 2026

Navigation Menu

Uh oh!

Uh oh!

std: move futex implementations into sys::sync::futex - #158726

std: move futex implementations into sys::sync::futex#158726
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
valentynkit:sys-sync-futex

valentynkit commented Jul 3, 2026 •

edited

Loading

Uh oh!

rustbot commented Jul 3, 2026

Uh oh!

rustbot commented Jul 29, 2026

Uh oh!

valentynkit commented Jul 29, 2026 •

edited

Loading

Uh oh!

Darksonn commented Aug 5, 2026

Uh oh!

jhpratt commented Aug 5, 2026

Uh oh!

rust-bors Bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

valentynkit commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 3, 2026

Uh oh!

rustbot commented Jul 29, 2026

Uh oh!

valentynkit commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Darksonn commented Aug 5, 2026

Uh oh!

jhpratt commented Aug 5, 2026

Uh oh!

rust-bors Bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

valentynkit commented Jul 3, 2026 •

edited

Loading

valentynkit commented Jul 29, 2026 •

edited

Loading