Skip to content

fix(cd): read release-please changelogs and attach to existing releases - #46

Merged
aryanjasala merged 2 commits into
mainfrom
fix/cd-github-release-release-please
Nov 5, 2026
Merged

aryanjasala merged 2 commits into
mainfrom
fix/cd-github-release-release-please

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

What this PR does

Makes cd-github-release.yml work for consumers that use release-please. Needed before #45 (see the AGENTS.md discussion there).

Closes

N/A

Changes

  • Reads release-please changelog headings (## [1.2.0](url) (date)) and component tags (acme-blocks-v1.2.0).
  • If the release already exists (release-please creates one), only attaches the asset. Otherwise creates the release as before.
  • No input changes.
  • AGENTS.md: the cd-github-release pitfall is now consumer guidance.
  • README.md: how to use it with release-please, including immutable releases.

How I verified

  • yamllint, actionlint and bin/check-workflows.sh pass.

Reviewer notes

@Adi-ty
Adi-ty marked this pull request as ready for review October 5, 2026 13:58
@Adi-ty
Adi-ty requested review from AnuragVasanwala and aryanjasala and a balanced review from Copilot October 5, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 4 High severity · 1 Medium severity · 1 Low severity

Open (6)
What changed in this PR

Updates the GitHub release CD reusable workflow to interoperate with release-please by reusing existing releases and correctly extracting notes from release-please-style changelog headings.

Changes:

  • Enhance cd-github-release.yml to detect existing releases and only upload assets when present (e.g., release-please-created releases).
  • Extend changelog section extraction to support release-please heading format and component-style tags.
  • Update docs (README.md, AGENTS.md) with guidance and pitfalls for release-please users.
File Description
README.md Adds release-please usage guidance and immutable releases publishing flow.
AGENTS.md Updates consumer guidance for cd-github-release.yml, including release-please formats and behavior.
.github/​workflows/​cd-github-release.yml Detects existing releases to attach assets only, and improves changelog parsing for release-please/component tags.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread README.md Outdated
Comment on lines +118 to +119
The action reads `release-please-config.json` and `.release-please-manifest.json` from the repository
root. For a manifest package at a path, read
# version, tolerating "## v1.2.3", "## 1.2.3", "## [1.2.3]", "## [v1.2.3]"
# and an optional trailing " - date". Exact token compare keeps "## Unreleased"
# and "## v1.2.30" from matching "v1.2.3".
if [[ "$TAG" =~ ^(.+-)?v?([0-9]+\.[0-9]+\.[0-9]+.*)$ ]]; then
Copilot AI balanced review requested due to automatic review settings October 5, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@Adi-ty
Adi-ty force-pushed the fix/cd-github-release-release-please branch from 3a17072 to 2fcb36d Compare November 4, 2026 06:32
Copilot AI balanced review requested due to automatic review settings November 4, 2026 06:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@aryanjasala
aryanjasala merged commit 13832e2 into main Nov 5, 2026
5 checks passed
aryanjasala added a commit to justlevine/wp-shared-workflows that referenced this pull request Nov 5, 2026
Brings in rtCamp#44, rtCamp#46, rtCamp#47, rtCamp#48 and rtCamp#49. AGENTS.md keeps this branch's
rule that release-please owns CHANGELOG.md, the manifest and v* tags,
and takes rtCamp#46's wording for cd-github-release.yml, which is consumer
guidance.

Drops the hand-written "## Unreleased" section rtCamp#47 added to
CHANGELOG.md: release-please inserts each release above the first
version heading, so that section would stay stranded above every
release. The first release PR lists rtCamp#46 to rtCamp#49 from their titles, and
rtCamp#47's fuller notes can go into that PR before it merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants