Skip to content

[wp-ci] Close the adoption gaps for consuming projects #51

Open

Description

@AnuragVasanwala

Repo: rtCamp/wp-shared-workflows
Milestone: v1.1.0
Priority: P1
Labels: Type: Story · Scope: CI Orchestrator · Priority: P1


Summary

A project that tried to move its CI onto these workflows in early October could not adopt any of them without local workarounds. The gaps below came out of that attempt. Most already have a pull request. This story merges them as one release so consumers can adopt wp-ci.yml as is, and decides release automation.

Gaps found

General

Per workflow

  • ci-lint-php: ignore_warnings_on_exit is hardcoded instead of read from .phpcs.xml.dist; PHPStan and PHPCS run as one step and should be independent; neither caches its result file; PHPStan output is not piped to cs2pr, so errors do not appear as PR annotations; PHPStan cannot run inside wp-env when it needs co-located plugins or themes
  • ci-build: no way to start wp-env or to build translations
  • ci-test-php: no coverage at all (no HTML artifact, no coverage token); wp-version does not accept latest or trunk; the wp-env script is fixed to npm run wp-env with no configurable test command; no retry on wp-env start; no caching of wp-env Docker images
  • detect-changes (workflow and script): file patterns cover .js only, not .mjs, .cjs, .jsx, .ts, .tsx (feat(detect-changes): count ES-module and TypeScript files in the js bucket wp-tooling#80)
  • ci-lint-js: ESLint only, no TypeScript type check; output not annotated on the PR
  • ci-test-js: no coverage reporting; Jest hardcoded, while @wordpress/scripts 36 defaults to Vitest

Intentional design decisions, to document rather than change

  • Actions pinned by SHA
  • Caller inputs passed through env: and run via bash -c, which blocks script injection from workflow inputs
  • Our own detect-changes script instead of a third-party action

In scope

Out of scope

Acceptance criteria

  • plugin-elementary and a second consumer repository both run on the released wp-ci.yml with no local workaround
  • Every gap above is closed, or recorded as intentional in the README
  • Changelog entry for the release

Depends on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Priority: P1High — sprint commitmentScope: CI Orchestratorwp-ci.yml + ci-detect-changesType: StoryGroup of related tasks within an epic

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions