Repository navigation
Open
Labels
Priority: P1High — sprint commitmentHigh — sprint commitmentScope: CI Orchestratorwp-ci.yml + ci-detect-changeswp-ci.yml + ci-detect-changesType: StoryGroup of related tasks within an epicGroup of related tasks within an epic
Milestone
Description
Repo: rtCamp/wp-shared-workflows
Milestone: v1.1.0
Priority: P1
Labels: Type: Story · Scope: CI Orchestrator · Priority: P1
Summary
A project that tried to move its CI onto these workflows in early October could not adopt any of them without local workarounds. The gaps below came out of that attempt. Most already have a pull request. This story merges them as one release so consumers can adopt wp-ci.yml as is, and decides release automation.
Gaps found
General
- Pinned third-party actions are several versions behind, and nothing updates them (chore: add dependabot to automanage dependency updates #44 adds Dependabot)
- Every workflow requires
node-version; it should fall back to.nvmrc, then to the current LTS (feat(ci): forward wp-ci inputs to leaves and resolve Node from .nvmrc #47) - Composer install and cache are custom steps; use
ramsey/composer-install(fix(ci): use ramsey/composer-install and drop checkout credentials #49).--no-scriptsalso blocks consumers that prefix dependencies in a Composer script persist-credentials: falseis missing on checkouts (fix(ci): use ramsey/composer-install and drop checkout credentials #49)- Releases are manual; chore: use
release-pleasefor release automation #45 proposes release-please with a GitHub flow
Per workflow
ci-lint-php:ignore_warnings_on_exitis hardcoded instead of read from.phpcs.xml.dist; PHPStan and PHPCS run as one step and should be independent; neither caches its result file; PHPStan output is not piped tocs2pr, so errors do not appear as PR annotations; PHPStan cannot run inside wp-env when it needs co-located plugins or themesci-build: no way to start wp-env or to build translationsci-test-php: no coverage at all (no HTML artifact, no coverage token);wp-versiondoes not acceptlatestortrunk; the wp-env script is fixed tonpm run wp-envwith no configurable test command; no retry onwp-env start; no caching of wp-env Docker imagesdetect-changes(workflow and script): file patterns cover.jsonly, not.mjs,.cjs,.jsx,.ts,.tsx(feat(detect-changes): count ES-module and TypeScript files in the js bucket wp-tooling#80)ci-lint-js: ESLint only, no TypeScript type check; output not annotated on the PRci-test-js: no coverage reporting; Jest hardcoded, while@wordpress/scripts36 defaults to Vitest
Intentional design decisions, to document rather than change
- Actions pinned by SHA
- Caller inputs passed through
env:and run viabash -c, which blocks script injection from workflow inputs - Our own
detect-changesscript instead of a third-party action
In scope
- Merge chore: add dependabot to automanage dependency updates #44, fix(cd): read release-please changelogs and attach to existing releases #46, feat(ci): forward wp-ci inputs to leaves and resolve Node from .nvmrc #47, feat(ci): install wp-tooling from npm #48, fix(ci): use ramsey/composer-install and drop checkout credentials #49 after review
- Decide chore: use
release-pleasefor release automation #45 (release-please): merge it, or record the reason not to - Coverage gate workflow inputs ([ci-test] Enforce changed-line test coverage on every pull request commit #36) and the consumer side in the starters
- Enable PHPStan in the starters' CI calls
- Squash-only merges on the shared repositories
- Document the intentional choices above in the README
- Tag the release and list the changes for consumers
Out of scope
- Add ci-test-bc reusable workflow (back-compat check) #12 ci-test-bc stays in this milestone as its own task
Acceptance criteria
- plugin-elementary and a second consumer repository both run on the released
wp-ci.ymlwith no local workaround - Every gap above is closed, or recorded as intentional in the README
- Changelog entry for the release
Depends on
Metadata
Metadata
Assignees
Labels
Priority: P1High — sprint commitmentHigh — sprint commitmentScope: CI Orchestratorwp-ci.yml + ci-detect-changeswp-ci.yml + ci-detect-changesType: StoryGroup of related tasks within an epicGroup of related tasks within an epic
Activity