Skip to content

Safely overwrite config files when moving temporary files #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlegrand62 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Safely overwrite config files when moving temporary files #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/romitask/cli/romi_run_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,9 +588,15 @@ def run_task(dataset_path, task, config, **kwargs):
# Move logging.cfg
shutil.move(logging_file_path, Path(dataset_path) / log_fname)
# Move the backup configuration file (scan.toml or pipeline.toml)
shutil.move(cfg_file_path, Path(dataset_path))
logger.info(f"Moved temporary config files to dataset directory "
f"'{Path(dataset_path)}'.")
# Ensure the destination file is overwritten if it already exists.
dest_cfg_path = Path(dataset_path) / Path(cfg_file_path).name
if dest_cfg_path.exists():
try:
dest_cfg_path.unlink() # Remove the existing file first
except Exception as e_unlink:
logger.error(f"Could not remove existing config file '{dest_cfg_path}': {e_unlink}")
raise
shutil.move(cfg_file_path, dest_cfg_path)
except Exception as move_err:
logger.error(f"Failed to move temporary config files: {move_err}")
# -------------------------------------------------------------
Expand Down
Loading