Skip to content

ci(ios): push the screenshots branch only when screenshots changed #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfazekas merged 1 commit into from
Oct 22, 2026
Merged

ci(ios): push the screenshots branch only when screenshots changed #4383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ios-nightly-percy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ jobs:
REFRESH_UNSTABLE: ${{ inputs.refresh_unstable }}

# Rebuilt on top of maps-docs main every time, so it never conflicts with the docs pushed
# to main by update-docs.yml. maps-docs opens the PR from it.
# to main by update-docs.yml. maps-docs opens the PR from it. Only examples-screenshots is
# compared with the existing branch, as main itself moves with almost every docs push.
- name: Push the screenshots branch
if: steps.download.outcome == 'success'
working-directory: maps-docs
Expand All @@ -159,7 +160,7 @@ jobs:
} > "$RUNNER_TEMP/message.txt"
git commit -q -F "$RUNNER_TEMP/message.txt"
cat "$RUNNER_TEMP/message.txt" >> "$GITHUB_STEP_SUMMARY"
if git fetch -q origin "$BRANCH" && git diff --quiet FETCH_HEAD HEAD; then
if git fetch -q origin "$BRANCH" && git diff --quiet FETCH_HEAD HEAD -- examples-screenshots; then
echo "$BRANCH is already up to date"
exit 0
fi
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/update-doc-screenshots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* examples-screenshots folder, drops screenshots of removed examples, keeps screenshots.json
* in sync and writes a markdown summary of what changed (empty if nothing did).
*
* excludeFromPercy examples differ by 2-80% between runs (animations, timers), so they are only
* excludeFromPercy examples differ by up to ~80% between runs (animations, timers), so they are only
* replaced when new, when the screenshot size changed or with REFRESH_UNSTABLE=true.
*/

Expand Down
Loading