Repository navigation
ci(ios): push the screenshots branch only when screenshots changed - #4383
Merged
Merged
Conversation
The skip compared whole trees, so every docs push to maps-docs main made the nightly force-push the branch again with unchanged screenshots.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4382: the screenshots branch skip compared whole trees, so every docs push to maps-docs
mainmade the nightly force-pushauto/example-screenshotsagain (and rewrite the maps-docs PR) even with unchanged screenshots. The comparison is now scoped toexamples-screenshots(which also holdsscreenshots.json), a missing branch still pushes, and the unstable-example range in the script header now reads "up to ~80%".Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing
Checked against a maps-docs clone: a screenshot commit on an older
main(c562ad4) vs. the same screenshots rebuilt on today'smain(da97c90) gives "differs" with the old condition and "same" with the new one; a changed PNG orscreenshots.jsonstill differs, and a missing branch still pushes. actionlint passes.