Repository navigation
feat!: expose file writer page options in dataset APIs - #89
Merged
Merged
Conversation
ilya-zlobintsev
added
upstream backport
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
ilya-zlobintsev
changed the title
amunra
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Manual port of upstream lance-format#9192
What
Exposes
FileWriterOptionsthroughWriteParams, like in the upstream PR.This is a manual port of just the part we care about rather than a cherry-pick because the latter had a lot of conflicts in the non-rust connectors as well as with plumbing the validation of params everywhere. I trust us to not set nonsensical params in our own code 🙂