Repository navigation
feat: expose data_cache_bytes through CompactionOptions - #92
Merged
Merged
Conversation
amunra
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
This option is settable for normal writes with #89, but not for compaction.
What
Allow
data_cache_bytesfromFileWriterOptionsto also be configured for compaction. The name is not super accurate in that it's more of a write buffer size, and has a big impact on memory usage of compaction on larger tables.Note: the value is not validated here, it will be in the upstream PR which has validation helpers for
FileWriterOptions