chore(deps): bump electron-builder to 26.15.3 and electron-updater to 6.8.9 - #1183
Merged
Conversation
This was referenced Aug 19, 2026
# Conflicts: # electron/package-lock.json # package-lock.json
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1151 and #1150, which were both red and overlap on
electron-builder. Doing the whole electron-builder family in one commit avoids the half-updated states those two produced.All within the same major.
Why the dependabot PRs failed
npm cirefused the tree: dependabot updatedelectron/package-lock.jsonandelectron/package.jsonbut not the rootpackage-lock.json, and sinceelectronis a workspace of the root, the root lock is whatnpm ciresolves. It exited withMissing: string_decoder@1.1.1 from lock fileand friends, so typecheck and CircleCI both failed before running anything. Both lockfiles are regenerated here, andnpm ci --dry-runis clean against each.Lockfile churn
The diff is large (~1100 insertions, ~2300 deletions) because 26.15.x drops the prebuilt
app-builder-binand7zip-binbinaries in favor of pure-TS equivalents, withnativeRebuilderrouting to@electron/rebuild. That also removesdmg-license,@develar/schema-utilsand a chunk of thecacachetree. Nothing in this repo's scripts or build config referenced those.Verification
npm ci --ignore-scripts --dry-runclean for the root lock and forelectron/package-lock.json— the exact failure from chore(deps): bump app-builder-lib and electron-builder in /electron #1151npx tsc -p common/tsconfig.json, rootnpm run typecheck, andnpx tsc -p tsconfig.json --noEmitinelectron/all clean. The electron typecheck is the meaningful one forelectron-updater:AutoUpdater.tsuseslogger,disableWebInstaller,autoRunAppAfterInstall,forceDevUpdateConfig,allowPrerelease,getFeedURL(),checkForUpdatesAndNotify()andquitAndInstall(), and all still typecheck against 6.8.9's typesnpm test— 2 suites, 20 tests passingelectron-builder --dir --mac --arm64(unsigned,SKIP_SIGNING=true) completes —@electron/rebuildruns the native-dependency step, electron 39.8.10 is downloaded and extracted, and the app packs to a 314 MB bundle withelectron-updaterpresent inapp.asarWhat still needs a human
The packaging internals changed under us, so this deserves a real signed build before it ships — notarization on macOS, the SSL.com signtool path on Windows, and an auto-update check against a published release. None of that is reachable from CI on a PR. 26.15.2 also switched the macOS zip target to native
zipto preserve.frameworksymlinks, and the mac zip is what feeds auto-update, so that path specifically is worth exercising on the next release candidate.