ci(node): read the node version from .nvmrc and bump setup-node to v4 - #1184
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1183. That PR pinned
node-version: 22in each workflow to clear therequire(esm)floor electron-builder 26.15 introduced, which left the Node version specified in two places..nvmrcalready saysv22.14.0, so the workflows now read it instead:Applied to all four workflows (typecheck, build-electron, build-android, build-ios). CI now tracks
.nvmrcexactly — 22.14.0 rather than "latest 22.x" — so a future bump there carries CI with it, and CI matches what developers get fromnvm use.Two places can't read the file and stay manual:
.circleci/config.ymlneeds a literal image tag (cimg/node:22.23.2)Both are above the floor. Anything that moves
.nvmrcbelow 20.19 / 22.12 would break the electron workspace's postinstall, so these want a glance if that version ever drops.setup-node v4
Second commit bumps
actions/setup-node@v3→@v4in build-electron, build-android and build-ios (typecheck was already on v4). v3 runs on the deprecated node16 action runtime, which GitHub warns about in current run logs.node-version-filebehaves the same on both, so this is a runtime bump rather than a behavior change.actions/checkout@v3is still in those three workflows and has the same deprecation, but it's left alone here — worth its own pass.