Skip to content

ci(node): read the node version from .nvmrc and bump setup-node to v4 - #1184

Merged
JamieRuderman merged 2 commits into
mainfrom
jr/ci-node-version-file
Aug 19, 2026
Merged

ci(node): read the node version from .nvmrc and bump setup-node to v4#1184
JamieRuderman merged 2 commits into
mainfrom
jr/ci-node-version-file

Conversation

@JamieRuderman

@JamieRuderman JamieRuderman commented Aug 19, 2026

Copy link
Copy Markdown
Member

Follow-up to #1183. That PR pinned node-version: 22 in each workflow to clear the require(esm) floor electron-builder 26.15 introduced, which left the Node version specified in two places. .nvmrc already says v22.14.0, so the workflows now read it instead:

      - uses: actions/setup-node@v4
        with:
          node-version-file: .nvmrc

Applied to all four workflows (typecheck, build-electron, build-android, build-ios). CI now tracks .nvmrc exactly — 22.14.0 rather than "latest 22.x" — so a future bump there carries CI with it, and CI matches what developers get from nvm use.

Two places can't read the file and stay manual:

  • .circleci/config.yml needs a literal image tag (cimg/node:22.23.2)
  • Amplify's Node comes from the console's Live package updates setting (currently 22)

Both are above the floor. Anything that moves .nvmrc below 20.19 / 22.12 would break the electron workspace's postinstall, so these want a glance if that version ever drops.

setup-node v4

Second commit bumps actions/setup-node@v3@v4 in build-electron, build-android and build-ios (typecheck was already on v4). v3 runs on the deprecated node16 action runtime, which GitHub warns about in current run logs. node-version-file behaves the same on both, so this is a runtime bump rather than a behavior change.

actions/checkout@v3 is still in those three workflows and has the same deprecation, but it's left alone here — worth its own pass.

@aws-amplify-us-west-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1184.d20k671nqqv4kl.amplifyapp.com

@JamieRuderman JamieRuderman changed the title ci(node): read the node version from .nvmrc instead of pinning it per workflow ci(node): read the node version from .nvmrc and bump setup-node to v4 Aug 19, 2026
@JamieRuderman
JamieRuderman merged commit 16a01a5 into main Aug 19, 2026
8 checks passed
@JamieRuderman
JamieRuderman deleted the jr/ci-node-version-file branch August 19, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant