Repository navigation
MOD-20386: Correct Iris suite operations guidance - #4487
Merged
rbs333 merged 1 commit intoNov 5, 2026
Merged
Conversation
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at 950204d |
rbs333
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
docs/iris-suite-1.0-operations)Ticket ID
MOD-20386
Link: https://redislabs.atlassian.net/browse/MOD-20386
Description
This follow-up corrects unsafe or misleading operational guidance found while checking #4470 against the Redis Iris 1.0.0 technical design, executable lifecycle runbooks, and release evidence.
It removes the Redis Open Source example that granted unrestricted
+@all,~*, and&*permissions, distinguishes metadata Redis entries from unrelated URLs in aggregate Secrets, and states the prerequisites and untested limitation of recovery without chart-generated Secrets. It also clarifies that Helm rollback does not undo Redis writes, uses the documented 15-minute upgrade and rollback timeout, and makes preflight validate the target chart version.The pull request is intentionally based on
docs/iris-suite-1.0-operationsso the original documentation pull request can take these corrections without mixing in unrelatedmainchanges.Testing
git diff --check: passed.ASDF_HUGO_VERSION=extended-0.143.0 asdf exec hugo --gc --logLevel warning: rendered the changed pages with no errors in either Iris page and no unresolved links from this change. The repository-wide run still reports existing missing PostCSS and generated-example prerequisites.pr-deep-review: six initial findings; six challenger-confirmed findings; all addressed.ponytail-review: passed with no remaining findings.Merge danger
Door: two-way. Documentation-only changes can be reverted independently.
Blast radius: Redis Iris self-managed install and operations guidance only.
Note
Low Risk
Documentation-only edits to Iris self-managed operations pages; no application or infrastructure code changes.
Overview
This PR tightens Redis Iris self-managed install and operations docs so they match safe lifecycle behavior rather than oversimplified Helm semantics.
Preflight now templates against
<chart-version>instead of a fixed1.0.0, so checks match the release you are about to install or upgrade.Upgrade and rollback examples add
--timeout 15malongside--atomic/--wait, and the text now states that atomic rollback restores Kubernetes resources and Helm values but does not revert data or metadata written to Redis. Rollback wording drops the incorrect implication that metadata Redis keys/grants are unchanged by rollback alone.Metadata Redis credential rotation replaces an Open Source
redis-cliexample that granted+@all,~*, and&*with guidance to mirror the current ACL user’s rules, persist ACLs correctly, and verify on every cluster node. Secret updates are scoped to metadata Redis connection entries in the values table, not every key in aggregate Secrets.Namespace recovery when chart-generated credential Secrets are lost now requires restoring customer-supplied Secrets first, limits agent-key continuity to a surviving Identity Service metadata database, and notes the path is documented but untested.
Reviewed by Cursor Bugbot for commit 950204d. Bugbot is set up for automated code reviews on this repo. Configure here.