Skip to content

[Symfony44] Cover ConsoleExecuteReturnIntRector try/catch with \Throwable and trailing comment #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomasVotruba wants to merge 1 commit into from
Closed

[Symfony44] Cover ConsoleExecuteReturnIntRector try/catch with \Throwable and trailing comment #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...44/Rector/ClassMethod/ConsoleExecuteReturnIntRector/Fixture/skip_try_catch_return.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ final class SkipTryCatchReturn extends Command
{
try {
return 0;
} catch (\Exception $e) {
} catch (\Throwable $e) {
return 1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...soleExecuteReturnIntRector/Fixture/skip_try_catch_return_with_stmts_before_return.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ final class SkipTryCatchReturnWithStmtsBeforeReturn extends Command
try {
$output->writeln('working');
return 0;
} catch (\Exception $exception) {
} catch (\Throwable $exception) {
$output->writeln($exception->getMessage());
return 1;
}
Expand Down
4 changes: 2 additions & 2 deletions ...d/ConsoleExecuteReturnIntRector/Fixture/try_catch_return_with_stmts_before_return.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ final class TryCatchReturnWithStmtsBeforeReturnCommand extends Command
try {
$output->writeln('working');
return 0;
} catch (\Exception $exception) {
} catch (\Throwable $exception) {
$output->writeln($exception->getMessage());
return 1;
}
Expand All @@ -37,7 +37,7 @@ final class TryCatchReturnWithStmtsBeforeReturnCommand extends Command
try {
$output->writeln('working');
return 0;
} catch (\Exception $exception) {
} catch (\Throwable $exception) {
$output->writeln($exception->getMessage());
return 1;
}
Expand Down
2 changes: 1 addition & 1 deletion rules/Symfony44/Rector/MethodCall/WebLinkStringRelationsToConstantsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function refactor(Node $node): ?Node
}

$constFetch = $this->createConstantFetch($valueNode->value);
if (! $constFetch) {
if (!$constFetch instanceof Node) {
return null;
}

Expand Down
Loading