[Symfony44] Cover ConsoleExecuteReturnIntRector try/catch with \Throwable and trailing comment - #1063
Closed
TomasVotruba wants to merge 1 commit into
Closed
[Symfony44] Cover ConsoleExecuteReturnIntRector try/catch with \Throwable and trailing comment#1063TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
… try/catch fixtures
TomasVotruba
force-pushed
the
console-execute-throwable-try-catch-fixtures
branch
from
September 8, 2026 19:27
4a38a2c to
ab06c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to rectorphp/rector-src#8472, covering the
ConsoleExecuteReturnIntRectorside of rectorphp/rector#9897.A
try/catch (\Throwable)where both branches return, and the catch ends with a trailing comment (parsed as aNop, e.g.// @codeCoverageIgnoreEnd), already returnsinton every path. The rule must not append an unreachablereturn 0;. New fixtureskip_try_catch_throwable_trailing_comment.php.incpins this.Existing
try/catchfixtures switched from\Exceptionto\Throwable: only a\Throwablecatch guarantees the block ends control flow, since anErrorescapes an\Exception-only catch. This matches the analyzer change in rector-src#8472.Depends on rectorphp/rector-src#8472 - CI here goes green once that lands and
dev-mainpicks it up (the trailing-comment skip relies on the Nop-skip added there).