[NodeAnalyzer] Treat trailing comment and infinite loop as terminating in last block stmts - #8472
Closed
TomasVotruba wants to merge 1 commit into
Closed
Conversation
… try/catch termination check
TomasVotruba
force-pushed
the
terminated-analyzer-trailing-comment-and-infinite-loop
branch
from
September 8, 2026 19:28
d852c9b to
0398dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
ConsoleExecuteReturnIntRectorfalse positive reported in rectorphp/rector#9897.TerminatedNodeAnalyzer::isTerminatedInLastStmts()only accepted aReturn_or anexit/throwexpression as the last statement of a block. Two cases slipped through and made a fully-terminatedtry/catchlook like it falls through:Nopstmt, hiding the real lastreturnwhile (true)/do/forinfinite loop with no break at the end of a block never falls through, but was not recognizedBoth now report the block as terminated, so no unreachable
return/statement is appended after such atry/catch.Covered with two
RemoveUnreachableStatementRectorfixtures (comment in catch, infinite while in try).